Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 7
Evaluate without impressions: add impressionsDisabled option to feature evaluation#452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
f4df1c923818e1dd9a447f12130457e244ff5b69600d75c9e7be328b25bd071fba8bb8e161a9ef26c5c7226bc67af41862File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to refactor the
validateEvaluationOptionsso that theimpressionsDisabledoption is only validated and used for the Evaluator, and for other SDKs it should be sanitized tofalse(or any other falsy value) to ignore the feature.Eventually, if the feature is included in SDKs, the change can be rolled back.