Skip to content

Update Trial so that goals are accessible in callback - #625

Merged
andrehjr merged 2 commits into
splitrb:masterfrom
robin-phung:trial-goal-callback
Jun 4, 2020
Merged

Update Trial so that goals are accessible in callback#625
andrehjr merged 2 commits into
splitrb:masterfrom
robin-phung:trial-goal-callback

Conversation

@robin-phung

@robin-phungrobin-phung commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

What problem does this solve?

When using goals the on_trial_complete does not have scope to the #ab_finished supplied goals.

How does this solve it?

Updates the Trial to initialize with goals so that they are accessible in the callback when passing the trial into the callback.

Notes: Fixed and cleaned up specs.

andrehjr
andrehjr reviewed Jun 4, 2020
View reviewed changes
Comment threadspec/trial_spec.rb Outdated
andrehjr
andrehjr reviewed Jun 4, 2020
View reviewed changes
Comment threadspec/trial_spec.rb Outdated
andrehjr
andrehjr approved these changes Jun 4, 2020
View reviewed changes

@andrehjrandrehjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for cleaning up those specs!

I've found a small typo. If you can fix that I'll merge :)

@robin-phung

robin-phung commented Jun 4, 2020

Copy link
Copy Markdown
ContributorAuthor

Oops! As suggested spec copy has been fixed!

@andrehjr
andrehjr merged commit 9e45dd1 into splitrb:masterJun 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrehjrandrehjrandrehjr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robin-phung@andrehjr