Fix mxint cast (for the last time) - #17
Merged
Merged
Conversation
|
|
||
| end | ||
|
|
||
| // ============================= |
Collaborator
There was a problem hiding this comment.
crazy stuff right here
luigirinaldi
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
mxint_castmodule in thesrc/mase_components/linear_layers/mxint_operators/rtl/mxint_cast.svfile and updates to the corresponding test filemxint_cast_tb.py. The changes aim to improve the handling of edge cases, enhance the accuracy of calculations, and update test parameters.Improvements to edge case handling and accuracy:
log2_max_valueis zero in the computation ofedata_outto avoid potential errors.shift_valueand introducedmax_valueto ensure accurate handling of large numbers and edge cases.mdata_outto use this function.Test parameter updates:
MAX_MANTISSAfrom 16 to 32 and adjusted the range forin_manandout_manin theget_mxint_cast_config_randomfunction to allow for a wider range of test cases.test_mxint_cast_randomfunction to reflect the new maximum values for mantissa and exponent widths.