Uh oh!
There was an error while loading. Please reload this page.
Add JSR-250 as a dependency to avoid compilation failures for Java9+ - #24
Open
anawara wants to merge 1 commit into
Open
Add JSR-250 as a dependency to avoid compilation failures for Java9+#24anawara wants to merge 1 commit into
anawara wants to merge 1 commit into
Conversation
codecov-io
commented
Jun 27, 2018
Codecov Report
@@ Coverage Diff @@## master #24 +/- ##
=========================================
Coverage 93.95% 93.95% Complexity 209 209 =========================================
Files 23 23 Lines 645 645 Branches 93 93 =========================================
Hits 606 606 Misses 30 30 Partials 9 9Continue to review full report at Codecov.
|
pettermahlen
commented
Jun 29, 2018
Member
What is the impact of this change? |
pettermahlen
commented
Jun 29, 2018
Member
Or, more precisely, what is the problem it's supposed to solve and how does it solve it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@togi@pettermahlen can you please review this?