Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212

Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom
Dockerel:docs/jpa-nested-tx-default
Closed

Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom
Dockerel:docs/jpa-nested-tx-default

Conversation

@Dockerel

@DockerelDockerel commented Jul 17, 2025•
edited
Loading

Copy link
Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc

  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”

The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.

/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}

This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.

Let me know if you have any concerns or suggestions for further improvement.
Thank you for your time and consideration!

@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 17, 2025
@sbrannensbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task labels Jul 17, 2025
@sbrannen
sbrannen requested a review from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed the docs/jpa-nested-tx-default branch from 4e8967a to 9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel changed the title Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel changed the title Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 28, 2025
@jhoellerjhoeller added this to the 6.2.10 milestone Jul 28, 2025
@jhoellerjhoeller changed the title Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller self-assigned this Aug 2, 2025
@jhoellerjhoeller modified the milestones: 6.2.10, 6.2.11Aug 13, 2025
@Dockerel

Dockerel commented Sep 5, 2025

Copy link
Copy Markdown
Author

Is there anything that i should do for this PR to be merged? @jhoeller

@jhoeller

jhoeller commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.

@Dockerel

Dockerel commented Sep 9, 2025

Copy link
Copy Markdown
Author

I see. Thank you for clarification!

@jhoellerjhoeller mentioned this pull request Sep 10, 2025
Closed
jhoeller added a commit that referenced this pull request Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions

github-actionsBot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Fixed via 5b38761

@Dockerel
Dockerel deleted the docs/jpa-nested-tx-default branch September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects

None yet

Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212
Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Closed
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Conversation
@Dockerel
@DockerelDockerel
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc
  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”
The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.
/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}
This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.
Let me know if you have any concerns or suggestions for further improvement.

Thank you for your time and consideration!
@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues
added
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 17, 2025
@sbrannensbrannen
added

in: data
Issues in data modules (jdbc, orm, oxm, tx)
type: documentation
A documentation task
labels
Jul 17, 2025
@sbrannen
sbrannen
requested a review
from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed
the
docs/jpa-nested-tx-default
branch
from
4e8967a to
9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel
changed the title
Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller
removed
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 28, 2025
@jhoellerjhoeller
added this to the 6.2.10 milestone
Jul 28, 2025
@jhoellerjhoeller
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller
self-assigned this
Aug 2, 2025
@jhoellerjhoeller
modified the milestones:
6.2.10, 6.2.11Aug 13, 2025
@Dockerel
Dockerel
commented
Sep 5, 2025

Copy link


Copy Markdown

Author
Is there anything that i should do for this PR to be merged? @jhoeller
@jhoeller
jhoeller
commented
Sep 8, 2025

Copy link


Copy Markdown

Contributor
@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.
@Dockerel
Dockerel
commented
Sep 9, 2025

Copy link


Copy Markdown

Author
I see. Thank you for clarification!
@jhoellerjhoeller
mentioned this pull request
Sep 10, 2025

Closed

jhoeller added a commit
that referenced
this pull request
Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions
github-actionsBot
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
Fixed via 5b38761
@Dockerel
Dockerel
deleted the

docs/jpa-nested-tx-default

branch
September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects


None yet


Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212
Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Closed
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Conversation
@Dockerel
@DockerelDockerel
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc
  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”
The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.
/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}
This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.
Let me know if you have any concerns or suggestions for further improvement.

Thank you for your time and consideration!
@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues
added
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 17, 2025
@sbrannensbrannen
added

in: data
Issues in data modules (jdbc, orm, oxm, tx)
type: documentation
A documentation task
labels
Jul 17, 2025
@sbrannen
sbrannen
requested a review
from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed
the
docs/jpa-nested-tx-default
branch
from
4e8967a to
9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel
changed the title
Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller
removed
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 28, 2025
@jhoellerjhoeller
added this to the 6.2.10 milestone
Jul 28, 2025
@jhoellerjhoeller
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller
self-assigned this
Aug 2, 2025
@jhoellerjhoeller
modified the milestones:
6.2.10, 6.2.11Aug 13, 2025
@Dockerel
Dockerel
commented
Sep 5, 2025

Copy link


Copy Markdown

Author
Is there anything that i should do for this PR to be merged? @jhoeller
@jhoeller
jhoeller
commented
Sep 8, 2025

Copy link


Copy Markdown

Contributor
@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.
@Dockerel
Dockerel
commented
Sep 9, 2025

Copy link


Copy Markdown

Author
I see. Thank you for clarification!
@jhoellerjhoeller
mentioned this pull request
Sep 10, 2025

Closed

jhoeller added a commit
that referenced
this pull request
Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions
github-actionsBot
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
Fixed via 5b38761
@Dockerel
Dockerel
deleted the

docs/jpa-nested-tx-default

branch
September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects


None yet


Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212
Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Closed
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Conversation
@Dockerel
@DockerelDockerel
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc
  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”
The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.
/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}
This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.
Let me know if you have any concerns or suggestions for further improvement.

Thank you for your time and consideration!
@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues
added
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 17, 2025
@sbrannensbrannen
added

in: data
Issues in data modules (jdbc, orm, oxm, tx)
type: documentation
A documentation task
labels
Jul 17, 2025
@sbrannen
sbrannen
requested a review
from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed
the
docs/jpa-nested-tx-default
branch
from
4e8967a to
9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel
changed the title
Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller
removed
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 28, 2025
@jhoellerjhoeller
added this to the 6.2.10 milestone
Jul 28, 2025
@jhoellerjhoeller
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller
self-assigned this
Aug 2, 2025
@jhoellerjhoeller
modified the milestones:
6.2.10, 6.2.11Aug 13, 2025
@Dockerel
Dockerel
commented
Sep 5, 2025

Copy link


Copy Markdown

Author
Is there anything that i should do for this PR to be merged? @jhoeller
@jhoeller
jhoeller
commented
Sep 8, 2025

Copy link


Copy Markdown

Contributor
@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.
@Dockerel
Dockerel
commented
Sep 9, 2025

Copy link


Copy Markdown

Author
I see. Thank you for clarification!
@jhoellerjhoeller
mentioned this pull request
Sep 10, 2025

Closed

jhoeller added a commit
that referenced
this pull request
Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions
github-actionsBot
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
Fixed via 5b38761
@Dockerel
Dockerel
deleted the

docs/jpa-nested-tx-default

branch
September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects


None yet


Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212
Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Closed
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Conversation
@Dockerel
@DockerelDockerel
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc
  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”
The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.
/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}
This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.
Let me know if you have any concerns or suggestions for further improvement.

Thank you for your time and consideration!
@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues
added
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 17, 2025
@sbrannensbrannen
added

in: data
Issues in data modules (jdbc, orm, oxm, tx)
type: documentation
A documentation task
labels
Jul 17, 2025
@sbrannen
sbrannen
requested a review
from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed
the
docs/jpa-nested-tx-default
branch
from
4e8967a to
9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel
changed the title
Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller
removed
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 28, 2025
@jhoellerjhoeller
added this to the 6.2.10 milestone
Jul 28, 2025
@jhoellerjhoeller
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller
self-assigned this
Aug 2, 2025
@jhoellerjhoeller
modified the milestones:
6.2.10, 6.2.11Aug 13, 2025
@Dockerel
Dockerel
commented
Sep 5, 2025

Copy link


Copy Markdown

Author
Is there anything that i should do for this PR to be merged? @jhoeller
@jhoeller
jhoeller
commented
Sep 8, 2025

Copy link


Copy Markdown

Contributor
@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.
@Dockerel
Dockerel
commented
Sep 9, 2025

Copy link


Copy Markdown

Author
I see. Thank you for clarification!
@jhoellerjhoeller
mentioned this pull request
Sep 10, 2025

Closed

jhoeller added a commit
that referenced
this pull request
Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions
github-actionsBot
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
Fixed via 5b38761
@Dockerel
Dockerel
deleted the

docs/jpa-nested-tx-default

branch
September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects


None yet


Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212
Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Closed
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Conversation
@Dockerel
@DockerelDockerel
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc
  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”
The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.
/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}
This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.
Let me know if you have any concerns or suggestions for further improvement.

Thank you for your time and consideration!
@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues
added
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 17, 2025
@sbrannensbrannen
added

in: data
Issues in data modules (jdbc, orm, oxm, tx)
type: documentation
A documentation task
labels
Jul 17, 2025
@sbrannen
sbrannen
requested a review
from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed
the
docs/jpa-nested-tx-default
branch
from
4e8967a to
9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel
changed the title
Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller
removed
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 28, 2025
@jhoellerjhoeller
added this to the 6.2.10 milestone
Jul 28, 2025
@jhoellerjhoeller
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller
self-assigned this
Aug 2, 2025
@jhoellerjhoeller
modified the milestones:
6.2.10, 6.2.11Aug 13, 2025
@Dockerel
Dockerel
commented
Sep 5, 2025

Copy link


Copy Markdown

Author
Is there anything that i should do for this PR to be merged? @jhoeller
@jhoeller
jhoeller
commented
Sep 8, 2025

Copy link


Copy Markdown

Contributor
@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.
@Dockerel
Dockerel
commented
Sep 9, 2025

Copy link


Copy Markdown

Author
I see. Thank you for clarification!
@jhoellerjhoeller
mentioned this pull request
Sep 10, 2025

Closed

jhoeller added a commit
that referenced
this pull request
Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions
github-actionsBot
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
Fixed via 5b38761
@Dockerel
Dockerel
deleted the

docs/jpa-nested-tx-default

branch
September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects


None yet


Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212
Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Closed
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Conversation
@Dockerel
@DockerelDockerel
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc
  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”
The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.
/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}
This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.
Let me know if you have any concerns or suggestions for further improvement.

Thank you for your time and consideration!
@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues
added
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 17, 2025
@sbrannensbrannen
added

in: data
Issues in data modules (jdbc, orm, oxm, tx)
type: documentation
A documentation task
labels
Jul 17, 2025
@sbrannen
sbrannen
requested a review
from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed
the
docs/jpa-nested-tx-default
branch
from
4e8967a to
9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel
changed the title
Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller
removed
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 28, 2025
@jhoellerjhoeller
added this to the 6.2.10 milestone
Jul 28, 2025
@jhoellerjhoeller
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller
self-assigned this
Aug 2, 2025
@jhoellerjhoeller
modified the milestones:
6.2.10, 6.2.11Aug 13, 2025
@Dockerel
Dockerel
commented
Sep 5, 2025

Copy link


Copy Markdown

Author
Is there anything that i should do for this PR to be merged? @jhoeller
@jhoeller
jhoeller
commented
Sep 8, 2025

Copy link


Copy Markdown

Contributor
@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.
@Dockerel
Dockerel
commented
Sep 9, 2025

Copy link


Copy Markdown

Author
I see. Thank you for clarification!
@jhoellerjhoeller
mentioned this pull request
Sep 10, 2025

Closed

jhoeller added a commit
that referenced
this pull request
Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions
github-actionsBot
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
Fixed via 5b38761
@Dockerel
Dockerel
deleted the

docs/jpa-nested-tx-default

branch
September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects


None yet


Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc - #35212
Closed
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Closed
Correct the default value of nestedTransactionAllowed in JpaTransactionManager javadoc#35212
Dockerel wants to merge 3 commits into
spring-projects:mainfrom 
Dockerel:docs/jpa-nested-tx-default
Conversation
@Dockerel
@DockerelDockerel
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

Correct the default value of nestedTransactionAllowed in Javadoc
  • Changed the default value in the Javadoc from false to true
  • For smoother wording, replaced "though, since" to "but" and “use” with “disallow”
The Javadoc for JpaTransactionManager currently states that the nestedTransactionAllowed flag defaults to false. However, the default constructor has been setting this flag to true.
/*** Create a new JpaTransactionManager instance.* <p>An EntityManagerFactory has to be set to be able to use it.* @see #setEntityManagerFactory*/publicJpaTransactionManager() {
setNestedTransactionAllowed(true);
}
This PR updates the documentation to align with the actual behavior, ensuring consistency between the code and its Javadoc.
Let me know if you have any concerns or suggestions for further improvement.

Thank you for your time and consideration!
@Dockerel
Correct the default value of nestedTransactionAllowed in Javadoc
bb83e54
Signed-off-by: Giheon Do <dgh0001@naver.com>
@spring-projects-issuesspring-projects-issues
added
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 17, 2025
@sbrannensbrannen
added

in: data
Issues in data modules (jdbc, orm, oxm, tx)
type: documentation
A documentation task
labels
Jul 17, 2025
@sbrannen
sbrannen
requested a review
from jhoellerJuly 17, 2025 10:02
@Dockerel
Clarify limitations of nested transactions in Javadoc
9d28e45
Signed-off-by: Giheon Do <dgh0001@naver.com>
@Dockerel
Dockerelforce-pushed
the
docs/jpa-nested-tx-default
branch
from
4e8967a to
9d28e45CompareJuly 21, 2025 06:46
@DockerelDockerel
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerJul 21, 2025
@DockerelDockerel
changed the title
Correct and clarify Javadoc default for nestedTransactionAllowed in JpaTransactionManagerCorrect the default value of nestedTransactionAllowed in JavadocJul 21, 2025
@jhoellerjhoeller
removed
the 
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Jul 28, 2025
@jhoellerjhoeller
added this to the 6.2.10 milestone
Jul 28, 2025
@jhoellerjhoeller
changed the title
Correct the default value of nestedTransactionAllowed in JavadocCorrect the default value of nestedTransactionAllowed in JpaTransactionManager javadocJul 28, 2025
@jhoellerjhoeller
self-assigned this
Aug 2, 2025
@jhoellerjhoeller
modified the milestones:
6.2.10, 6.2.11Aug 13, 2025
@Dockerel
Dockerel
commented
Sep 5, 2025

Copy link


Copy Markdown

Author
Is there anything that i should do for this PR to be merged? @jhoeller
@jhoeller
jhoeller
commented
Sep 8, 2025

Copy link


Copy Markdown

Contributor
@Dockerel this has been postponed to reconsider the intended default for nestedTransactionAllowed. Arguably, it should be as the javadoc days for JPA which we consider fixing in 7.0. In that case, we should add a note in 6.2.11 that the default is wrong.
@Dockerel
Dockerel
commented
Sep 9, 2025

Copy link


Copy Markdown

Author
I see. Thank you for clarification!
@jhoellerjhoeller
mentioned this pull request
Sep 10, 2025

Closed

jhoeller added a commit
that referenced
this pull request
Sep 10, 2025
@jhoeller
Clarify intended nestedTransactionAllowed default in JpaTransactionMa…
5b38761
…nager
Closesgh-35212
@github-actions
github-actionsBot
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
Fixed via 5b38761
@Dockerel
Dockerel
deleted the

docs/jpa-nested-tx-default

branch
September 14, 2025 08:07
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhoellerjhoellerAwaiting requested review from jhoeller

Assignees

@jhoellerjhoeller

Labels

in: dataIssues in data modules (jdbc, orm, oxm, tx)type: documentationA documentation task

Projects


None yet


Milestone

6.2.11

Development

Successfully merging this pull request may close these issues.

4 participants

@Dockerel@jhoeller@sbrannen@spring-projects-issues