Conversation
raihei
commented
Jan 18, 2025
Contributor
@spuder Any reason you did not merge this pull request yet? I tested it and it works for me. |
spuder
commented
Jan 21, 2025
OwnerAuthor
The actual bug is in in the automation.yaml, pushed a new change that removes the upload button. |
raihei
commented
Jan 21, 2025
Contributor
Sorry, I don't get it. Why not push that fix in the main branch? And why remove the button? |
spuder
commented
Jan 21, 2025
OwnerAuthor
I'm sitting on the branch because I haven't had time to test it yet That button is a legacy button that wasn't really intended to be used. If people use it we could leave it however it has a completely different code path that would need to be refactored. |
raihei
commented
Jan 21, 2025
Contributor
I see, thanks for clarifying. That's true, it is probably rarely used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#28