Incorrect FieldType resolution for closed generic

[iskiselev]

Incorrect FieldType resolution for closed generic. Test case:

using System;

public static class Program
{
    public static class TmpClss<T>
    {
        public static T CallSite;
    };

    public static void Main(string[] args)
    {
        if (TmpClss<Action>.CallSite == null)
        {
            TmpClss<Action>.CallSite = () => Console.WriteLine("!");
        }
        var action = TmpClss<Action>.CallSite;
        RunMe();

        action();
    }

    public static void RunMe()
    {
        TmpClss<Action>.CallSite = () => Console.WriteLine("!!");
    }
}

Translation:

  function Program_Main (args) {
    if ($T02().CallSite === null) {
      $T02().CallSite = $T03().New(null, null, new JSIL.MethodPointerInfo($thisType, "$lMain$gb__0", $S00(), true, false));
    }
    var action = JSIL.CloneParameter(T, $T02().CallSite);
    $thisType.RunMe();
    action();
  }; 

We have problem with next line: JSIL.CloneParameter(T, $T02().CallSite). Here field type is know at compile time - it is Action, so there should not be JSConditionalStructCopyExpression at all.
Root cause of this problem:
When we create MemberIdentifier for FieldReference, owner type for field is closed generic type. Unfortunately, FieldReference still treat its type as GenericParameter "T", instead of using resolved type from owner type.

[kg]

gaaaaaaaaaaaaaaaaah.

Yeah, kinda makes sense.

[iskiselev]

Looks like this rabbit hole is much deeper that I've supposed.
It is really easy to fix this issue for FieldReference - we just need change JSField.GetActualType with TypeAnalysis.GetFieldType(Reference); and remove JSFieldAccess.GetActualType custom override.

But we have totally same problem with Properties and probably Methods/Events.
Looks like there was even attempt to fix it for properties:

        public override TypeReference GetActualType (TypeSystem typeSystem) {
            if (Property.ReturnType.IsGenericParameter)
                return SubstituteTypeArgs(Property.Source, Property.ReturnType, Reference);
            else
                return Property.ReturnType;
        }

But I'm afraid that it contains mistake - ReturnType could be not generic parameter, but open generic type that still could be resolved. So, probably we should always call SubstituteTypeArgs and probably update it too.
We should also review same for Methods/Events.