This repository was archived by the owner on Aug 24, 2022. It is now read-only.
Conversation
…ories list in assembly resolver Fix threading issues with AssemblyResolver
Member
|
Looks fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest ILSpy reference Mono.Cecil as submodule. It will be really hard to make changes in Cecil (as it will be second level submodule) after we upgrade it.
Fortunately, we have only one change in Cecil: in BaseAssemblyResolver class. Really, we need this change only when we use JSIL.Internal.AssemblyResolver, so we could move it there. After it, we'll be able to use no-patched Mono.Cecil version.
This PR is not fully equivalent to original change - I've added lock to all Resolve method instead of checking assembly path, but it should not affect us great.