Uh oh!
There was an error while loading. Please reload this page.
#435: show spinner indicating page is loading - #449
Open
djyotta wants to merge 16 commits into
Open
Conversation
djyotta
marked this pull request as draft
June 23, 2024 21:42
djyotta
commented
Jun 23, 2024
ContributorAuthor
@lovasoa can you take a look to see if it's ok in principle before I start on documentation? |
djyotta
commented
Jun 26, 2024
Uh oh!
There was an error while loading. Please reload this page.
djyotta
marked this pull request as ready for review
June 26, 2024 05:24
djyotta
commented
Jun 27, 2024
| The name of a [spinner](https://tabler.io/docs/components/spinners) (from tabler.io). | ||
| Default is "spinner-border". | ||
| Set to the empty string to disable the spinner - e.g. to display only progress | ||
| updates. |
ContributorAuthor
There was a problem hiding this comment.
I've noticed this whole approach doesn't work inside run_sql for some reason. So I should note that 'loader-start' component should be selected before descending into run_sql.
Collaborator
There was a problem hiding this comment.
Yes, run_sql is a function, it returns a single json value all at once, it can't stream its results.
ContributorAuthor
There was a problem hiding this comment.
I thought as much but didn't want to assume. It's good to have the clarification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#435