refactor: ask the dialect whether it is positional - #6
Merged
Conversation
sqlx-cel now answers this itself, so the local inference goes. The comparison it made is the trait's default, which is why nothing in the test suite changes -- including the custom `?1` dialect, which does not override the method and so exercises that default and gets the same answer the local copy gave. The reasoning moves upstream with the code: `Dialect::is_positional` documents why the property matters and what the middle case is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to sqlx-contrib/sqlx-cel#4, which added
Dialect::is_positional.The local inference in
cursor.rsgoes away — the trait answers it now:The comparison the local helper made is the trait's default, so nothing in the
test suite changes. That includes the custom
?1dialect incursor.rs's tests,which does not override the method and therefore exercises upstream's default
and gets the same answer the local copy gave — a useful cross-check that the
move was behaviour-preserving rather than merely compiling.
The reasoning moved upstream with the code, so the doc comment here just points
at
Dialect::is_positionalinstead of restating it and apologising forinferring a behavioural property from rendered text.
Testing
34 unit tests, 6 doctests, 6 SQLite round-trips, 6 Postgres round-trips; fmt,
clippy and
cargo doc -D warningsclean.