Uh oh!
There was an error while loading. Please reload this page.
Supplementary Tracking Issues Take 2 - #520
Merged
Merged
Conversation
added 2 commits
January 10, 2024 13:23
kyleve
marked this pull request as ready for review
January 11, 2024 13:51
kyleve
commented
Jan 11, 2024
ContributorAuthor
Tests are green, should be good to land: https://square-console.sqprod.co/bbr/production/ci_jobs/PR+ios+HJLRR6+Bazel-Pipeline-PR/2 (The one failure is the linter complaining at public github) |
kyleve
commented
Jan 12, 2024
ContributorAuthor
n8chur
approved these changes
Jan 12, 2024
| addGestureRecognizer(panGestureRecognizer) | ||
| let tapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(handleTap)) | ||
| tapGestureRecognizer.require(toFail: panGestureRecognizer) | ||
| tapGestureRecognizer.cancelsTouchesInView = false |
ContributorAuthor
There was a problem hiding this comment.
Weird that's showing up here, it's in main#521
Collaborator
There was a problem hiding this comment.
huh... I wonder if merging main into this would resolve the confusion GitHub's having here.
ContributorAuthor
There was a problem hiding this comment.
Merging main in seemed to resolve this, odd
* main: fix: don't cancel touches in view for tap gesture recognizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings back #433. Please see that PR for the discussion.
Describe your changes here. Please include screenshots if they're visual!
Checklist
Please do the following before merging:
Mainsection.