Uh oh!
There was an error while loading. Please reload this page.
Custom Update Animations - #539
Merged
Merged
Conversation
kyleve
commented
Jul 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
added 2 commits
July 18, 2024 20:38
robmaceachern
approved these changes
Jul 23, 2024
| } | ||
| /// A faster animation than the default `UICollectionView` animation. | ||
| public static let fast : Self = .init { animations in |
There was a problem hiding this comment.
These types of names have a bad habit of scaling weirdly: fast, faster, fastest, xxxFastest. Probably not a big deal but might be worth spending a few minutes brainstorming alternative naming conventions.
ContributorAuthor
There was a problem hiding this comment.
Hmm, true. I could mirror the Market-style naming of fast10, fast20, or something similar?
There was a problem hiding this comment.
Yeah not bad. Or replace fast with duration? e.g. duration{n}?
ContributorAuthor
There was a problem hiding this comment.
Actually, hmm, the more I think about it I'm not convinced this is super understandable honestly if you're not familiar with our Market token naming. I'm just going to leave this as is given it's unlikely we'll ever want more variants, I imagine... (famous last words)
kyleve
enabled auto-merge (squash)
July 31, 2024 23:30
kyleve pushed a commit
that referenced
this pull request
Aug 1, 2024
* origin/main: Prepare 14.3.0 (#540) Custom Update Animations (#539) Update version to 14.2.0 Prepare 14.2.0 release, which contains a Blueprint update Bumping versions to 14.1.0 (#535) reorder control now proxies accessibility into a seperate element (#533) Prepare 14.0.3 Fix a crash that could occur during cell reuse if a list contained different types of headers. The wrong ObjectIdentifier was being compared and stored. Get a repro for the reordering crash reported in #market-ios chore: Generated documentation now uses a static copyright notice to avoid noisy diffs (#530) Bumping versions to 15.0.2 fix: Fix tap gesture swallowing touches in swipe actions view Bump to 14.0.1 Fix SPM Blueprint dependency Release 14.0.0, update BlueprintUI to 3.0.0 (#525) chore: iOS 15 deployment target bump [UI-5187] (#524) chore: Bump CI to Xcode 15.1. Bump gems. [UI-5186] (#523) fix: don't cancel touches in view for tap gesture recognizer Revert weak change Revert "Revert "Supplementary Tracking Fixes (#433)""
kyleve pushed a commit
that referenced
this pull request
Aug 6, 2024
…rovements * origin/main: (33 commits) Prepare 14.3.0 (#540) Custom Update Animations (#539) Update version to 14.2.0 Prepare 14.2.0 release, which contains a Blueprint update Bumping versions to 14.1.0 (#535) reorder control now proxies accessibility into a seperate element (#533) Prepare 14.0.3 Fix a crash that could occur during cell reuse if a list contained different types of headers. The wrong ObjectIdentifier was being compared and stored. Get a repro for the reordering crash reported in #market-ios chore: Generated documentation now uses a static copyright notice to avoid noisy diffs (#530) Bumping versions to 15.0.2 fix: Fix tap gesture swallowing touches in swipe actions view Bump to 14.0.1 Fix SPM Blueprint dependency Release 14.0.0, update BlueprintUI to 3.0.0 (#525) chore: iOS 15 deployment target bump [UI-5187] (#524) chore: Bump CI to Xcode 15.1. Bump gems. [UI-5186] (#523) fix: don't cancel touches in view for tap gesture recognizer fix: don't cancel touches in view for tap gesture recognizer Revert weak change ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a way to customize the animation speed of a list. We want this for the checkout applet carts, where the default is too slow.
Checklist
Please do the following before merging:
Mainsection.