Uh oh!
There was an error while loading. Please reload this page.
Fixes #9 - #17
Conversation
Keys allowed in the A-Z and 0-9 range cleanup
pforhan
commented
Aug 4, 2015
Looks like this broke a test. You might wish to use Character.isJavaIdentifierPart() or Character.isLetterOrDigit() for something that reads a bit better. Of course, either could vastly expand the set of characters allowed, so they may not be a good idea. Aside from that, this change also allows the first character to be |
briangriffey
commented
Aug 5, 2015
Oops, forgot to check that test in. I can do that when I get to work tomorrow. Regarding the first char being a _ or number, I'm unsure why the restriction of "Keys start with lowercase letters followed by lowercase letters and underscores." was chosen. If I was adding capital letters it seems equally as arbitrary to start with a _. But I can change the code to whatever fits the project goals. |
There was a problem hiding this comment.
Extra line. Square conventions only divide between imports and static imports
loganj
commented
Feb 4, 2016
briangriffey
commented
Feb 4, 2016
We needed it for our internal translation system. Also why not is always a good reason :-D |
loganj
commented
Feb 4, 2016
It looks like keys will be case-sensitive though. |
briangriffey
commented
Feb 4, 2016
I guess that's a consequence of allowing both upper case and lower case. I'm actually fine with you punting this from the main repo. It's probably not a solution that everyone needs. We can merge into our fork when necessary. |
loganj
commented
Feb 4, 2016
Well, it could be case-insensitive. |
rocboronat
commented
Mar 10, 2016
Hi guys! We just had this issue with our team. A guy that is just introduced to Android was trying to replace {homeAddress}, and the library was launching a "Missing right bracket }". The reason to accept non-lowercase chars is not a "Why not?". It's just "what people expects". Thanks for the good work! |
miquelo
commented
Mar 10, 2016
+1 |
mohamedkomalo
commented
Aug 9, 2016
I have just faced the same problem by @rocboronat, it is the normal thing to expect especially when lots of people use camelCase, at least put a note in the readme that only lowercase letters is supported. |
Now supports A-Za-z0-9_ keys