Skip to content

More clear error messages for invalid characters - #35

Merged
loganj merged 2 commits into
square:masterfrom
pforhan:master
Oct 17, 2017
Merged

More clear error messages for invalid characters#35
loganj merged 2 commits into
square:masterfrom
pforhan:master

Conversation

@pforhan

@pforhanpforhan commented Jul 21, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Tweaks invalid start- and end-of-token messages for clarity.

Inspired by #33, fixes#32 and fixes#34, probably #29 as well.

@pforhanpforhan mentioned this pull request Jul 21, 2017
Closed
@pforhan

pforhan commented Jul 21, 2017

Copy link
Copy Markdown
ContributorAuthor

Not sure what's up with the CI build, a ./gradlew clean build comes back successful for me.

@pforhan

pforhan commented Jul 21, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

ci says:

failed to find target with hash string 'android-23' in: /usr/local/android-sdk

@zach-klippenstein

zach-klippenstein commented Jul 26, 2017

Copy link
Copy Markdown
Collaborator

LGTM 👌

@pforhan
More clear error messages for invalid characters
aa3ec64
Tweaks invalid start- and end-of-token messages for clarity.
Inspired by square#33, fixessquare#32 and square#34, probably square#29 as well.
@pforhan

pforhan commented Jul 26, 2017

Copy link
Copy Markdown
ContributorAuthor

Pushed a small change to help users differentiate the first-character message from the error later on.

@pforhan

pforhan commented Aug 14, 2017

Copy link
Copy Markdown
ContributorAuthor

@JakeWharton@rjrjr@loganj anyone interested in merging this?

@rjrjr

rjrjr commented Aug 14, 2017

Copy link
Copy Markdown
Contributor

LGTM, but can we figure out why the Travis is failing?

@pforhan

pforhan commented Aug 14, 2017

Copy link
Copy Markdown
ContributorAuthor

I think this is it:

Package Android SDK Platform-tools, revision 26 not installed due to rejected license 'android-sdk-license-c81a61d9'.

@pforhan

pforhan commented Aug 14, 2017

Copy link
Copy Markdown
ContributorAuthor

That passed. Pushed a small formatting fix for the .travis.yml file

@pforhan

pforhan commented Aug 14, 2017

Copy link
Copy Markdown
ContributorAuthor

Sigh, and another -- I added the newline to the wrong place

@pforhan

pforhan commented Aug 14, 2017

Copy link
Copy Markdown
ContributorAuthor

Green!

@pforhanpforhan mentioned this pull request Aug 31, 2017
Closed
@pforhan

pforhan commented Oct 16, 2017

Copy link
Copy Markdown
ContributorAuthor

Can I get a merge here? I think this is a good usability improvement that will head off more issues like #36

@loganj
loganj merged commit 66a2dc9 into square:masterOct 17, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rjrjrrjrjrrjrjr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@pforhan@zach-klippenstein@rjrjr@loganj