Uh oh!
There was an error while loading. Please reload this page.
Kotlin: escape keyword-named oneofs in toString() - #3675
Merged
oldergod merged 1 commit intoAug 14, 2026
Conversation
With escapeKotlinKeywords, generateToStringMethod emitted the oneof's interpolated value as a raw name instead of going through KotlinPoet's %N. The null check right above it and both usages in the Field branch already used %N, so only the oneof interpolation went unescaped: if (`in` != null) result += """in=$in""" which doesn't compile. Emit it with %N like everywhere else: if (`in` != null) result += """in=$`in`""" Closes#3674
oldergodforce-pushed
the
bquenaudon.2026-08-14.tostring-escape-oneof-keyword
branch
from
August 14, 2026 13:42
0c15429 to
d2a87d8Compareoldergod
marked this pull request as ready for review
August 14, 2026 13:43
staktrace
approved these changes
Aug 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
oldergod
deleted the
bquenaudon.2026-08-14.tostring-escape-oneof-keyword
branch
August 14, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#3674.
With
escapeKotlinKeywords = true, a oneof whose name is a Kotlin keyword produced atoString()that doesn't compile:generateToStringMethod'sOneOfbranch emitted the interpolated value as a rawadd(fieldName)rather thanadd("%N", fieldName).%Nis what makes KotlinPoet backtick-escape a keyword. The null check directly above it already used%N, as do both usages in theFieldbranch — only the oneof interpolation was raw, hence the asymmetric output in the issue.Now:
The label text on either side (
add(fieldName)for thein=prefix) stays unescaped — that's literal content of the output string, not an identifier.cc @bjoernmayer@adityaanikam