Skip to content

Fix: Region updates and URL changes for NinjaOne plugin - #77

Open
Deenk wants to merge 2 commits into
mainfrom
fix-ninjaone-eu-region
Open

Fix: Region updates and URL changes for NinjaOne plugin#77
Deenk wants to merge 2 commits into
mainfrom
fix-ninjaone-eu-region

Conversation

@Deenk

@DeenkDeenk commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

Quite a simple region change for the EU region for the NinjaOne plugin. This does not break existing EU region customers as the new/changed URL resolves to the same API. This change is needed though as some NinjaOne customers do require eu.ninjarmm.com. The existing eu-api.ninjarmm.com URL that the plugin uses is an alias that seemingly not all customers can use.

I have also updated the other regions so they use this newer URL format from NinJaOne. Although we do not have every region to test against, I have verified that any updated URLs do resolve to the same IP addresses as the previous, so they hit the same APIs which wont break anything for existing users.


🔗 Related issue(s)

https://squaredup-eng.atlassian.net/browse/PLUG-4662


🧩 Plugin details

  • Plugin name:
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

If yes, describe:

  • What breaks
  • Who is impacted
  • Any migration steps

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

Summary by CodeRabbit

  • Bug Fixes
    • Updated the NinjaOne API base URL settings to use the latest endpoint hostnames (including Canada and EU), ensuring requests go to the correct regional services.
  • Chores
    • Bumped the NinjaOne plugin version to 1.1.14.

@coderabbitai

coderabbitaiBot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated NinjaOne regional API base URL hostnames in ui.json and incremented the plugin version from 1.1.12 to 1.1.14 in metadata.json.

Changes

NinjaOne endpoint and version update

Layer / File(s)Summary
Endpoint configuration and version update
plugins/NinjaOne/v1/ui.json, plugins/NinjaOne/v1/metadata.json
Regional apiBaseUrl option values and the default hostname are updated while labels remain unchanged; the plugin version is incremented to 1.1.14.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title clearly identifies the NinjaOne region and URL changes.
Description check✅ PassedThe description explains the region URL changes, impact, testing, related issue, breaking changes, and documentation status.

Comment @coderabbitai help to get the list of available commands.

@Deenk
Deenk marked this pull request as ready for review July 1, 2026 09:36
@Deenk
Deenk requested a review from a teamJuly 1, 2026 09:36
@DeenkDeenk changed the title fix eu region for customerFix: EU region URL change for NinjaOne pluginJul 1, 2026
Comment threadplugins/NinjaOne/v1/ui.json
Switches US/US2/CA/OC to the documented app./us2./ca./oc.ninjarmm.com
hostnames instead of the api./-api variants, matching the same fix
already applied to EU to avoid the same class of region-URL issue.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/NinjaOne/v1

📋 Results

StepStatus
Validation✅ Passed
Deployment🚀 Deployed

🔍 Validation Details

ninja-one
{
"valid": true,
"pluginName": "ninja-one",
"pluginType": "cloud",
"summary": {
"Data Streams": 37,
"Import Definitions": 1,
"UI Configuration": true,
"Has Icon": true,
"Has Default Content": true,
"Config Validation": true,
"Custom Types": true
}
}

@Deenk
Deenk requested a review from clarkdJuly 14, 2026 16:35
@clarkd

Copy link
Copy Markdown
Member

Are we able to test this change with other regions or confident this will work as expected?

@clarkd
clarkd requested review from AliceG-Sq and vinbabJuly 21, 2026 12:50
@vinbab

Copy link
Copy Markdown
Contributor

Are we able to test this change with other regions or confident this will work as expected?

@Deenk@clarkd

  • I'd change the title and description to reflect the change (all regions).
  • We have 8 tenants in US and 5 in EU. I'd feel a lot more comfortable to approve if indeed we could confirm these two regions still work fine, for new and existing plugins.

@fionawhite
fionawhite removed the request for review from AliceG-SqJuly 22, 2026 10:09
@fionawhitefionawhite self-assigned this Jul 22, 2026
@fionawhite

Copy link
Copy Markdown

@Deenk@vinbab Are we planning to merge this PR, or move the plugin into the private repo first?

@Deenk

Copy link
Copy Markdown
ContributorAuthor

@Deenk@vinbab Are we planning to merge this PR, or move the plugin into the private repo first?

@fionawhite i vote to merge this now, then we can move the plugin when this fix is in place.

Does that sound okay @vinbab ?

@fionawhite

Copy link
Copy Markdown

@Deenk@vinbab Are we planning to merge this PR, or move the plugin into the private repo first?

@fionawhite i vote to merge this now, then we can move the plugin when this fix is in place.

Does that sound okay @vinbab ?

Ok. In terms of testing, did you manage to confirm it's still working in the other regions?

Looks like there's also an outstanding comment above from Vincent about the title and description.

@DeenkDeenk changed the title Fix: EU region URL change for NinjaOne pluginFix: Region updates and URL changes for NinjaOne pluginAug 3, 2026
@Deenk

Deenk commented Aug 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Are we able to test this change with other regions or confident this will work as expected?

@Deenk@clarkd

  • I'd change the title and description to reflect the change (all regions).
  • We have 8 tenants in US and 5 in EU. I'd feel a lot more comfortable to approve if indeed we could confirm these two regions still work fine, for new and existing plugins.

@vinbab@fionawhite Sorry missed this comment!

I have now updated the PR title to be more accurate for all URL changes we are making here.

Unfortunately we don't have all of these NinjaOne regions to test against. However, I have verified that any region URLs we are changing resolve to the exact same IP address range as the old URLs. This means that even though we are updating the URLs they point to the exact same API and wont break anything for existing users.

@fionawhitefionawhite removed their assignment Aug 4, 2026

@vinbabvinbab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving purely based on Dan's reply to my comments.
I have not tested this change. It should be easy to revert if a problem arises but sounds like Dan has tested this correctly.
@Deenk I would suggest that you take a snapshot per tenant of the NinjaOne data source status (green, red not indexing, SquaredUp Internal should have that data) and verify after the merge (it'll probably take up to 12 hours to re-index) that those data sources are still in their state before merge.
Also, do not merge to go-live to all customers on a Friday :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Deenk@clarkd@vinbab@fionawhite