Laravel 10 support

[manavo]

Hi,

First time contributing so sorry if it's not quite right!

Tried to get everything passing in Actions, and hopefully all the edits are correct. Just trying to add Laravel 10 support.

Happy to make any changes if needed. Also changing some dependencies might mean this has to be a new major version? Either way, I've worked off the 3.x branch.

Thanks!

[aglipanci]

@manavo I am afraid your PR will break support for PHP8.0 which doesn't have to be for Laravel 8 and 9.

[manavo]

Laravel 10 has PHP 8.1 as a minimum requirement, so I'm not sure what other options there are?

[aglipanci]

@manavo that is true indeed, however the package is support to work for Laravel 8 up to 10, that means that for older versions of Laravel only the older version of the package can be used. Anyway let's see what the maintainers have to say as I haven't actually tested myself.

Great work on the PR anyway!

[manavo]

That's why I'm guessing that it might have to be a new major version. Although Laravel 8 and 9 should work fine on PHP 8.1, right? So maybe that's still an OK middle ground.

[aglipanci]

Yes they should work fine with 8.1 but that doesn't mean that everyone is using them with the latest version of PHP though. There might be other reasons that people might be using PHP 8.0. If there will be a major version this should work fine.

Anyway I am just assuming :D

[manavo]

We'll leave those big decisions for @danharrin 😁

[danharrin]

Please retain PHP 8.0 support for now, as we still support Laravel 9

[manavo]

Hi @danharrin, not sure that's possible, with Laravel 10 requiring PHP 8.1?

[danharrin]

Composer will handle it based on the Laravel version.

[manavo]

I updated the composer.json file to allow PHP 8.0, if that's what you meant? And I guess it'll resolve whatever is required according to that?

[aglipanci]

@manavo revert lines like this as well: https://github.com/squirephp/squire/pull/59/files#diff-b2f45ba596f678a8771422eaa427e1847082d903afd19efc63f75cbfb20243aaR20

[manavo]

Good catch, thanks @aglipanci, just updated the packages too!

[aglipanci]

Awesome @manavo !

@danharrin you can try to run the workflows and review whenever you can :)

[danharrin]

Thanks @manavo and @aglipanci!