Use CollectionAssert in ListDirectory tests

[Rob-Hague]

These tests were failing for me because the files were coming in in a different order

Plus, CollectionAssert.AreEquivalent gives a nice failure message

[WojciechNagorski]

Can you tell me in what order you got the results?
I don't have full knowledge about the project yet, but perhaps the problem is not checking, but a random order.

[Rob-Hague]

 Create_directory_with_contents_and_list_it
Source: SftpClientTests.cs line 21
Duration: 172 ms
Message: Assert.AreEqual failed. Expected:</home/sshnet/sshnet-test/. False True
/home/sshnet/sshnet-test/.. False True
/home/sshnet/sshnet-test/test-file.txt True False
>. Actual:</home/sshnet/sshnet-test/test-file.txt True False
/home/sshnet/sshnet-test/. False True
/home/sshnet/sshnet-test/.. False True
>. 

Same for Create_directory_with_contents_and_list_it_async

I have not looked at the implementation, but I would not expect it to do any sorting - the user can sort the files how they like.

[WojciechNagorski]

It needs to be checked. I don't know if it shouldn't be deterministic.

[Rob-Hague]

So the directory listing functionality is the sending of a SSH_FXP_READDIR packet. I do not see anything relating to sort order in the RFC and the library implementation is reading out the filenames as they are returned (into an array, and then a list).

SSH.NET/src/Renci.SshNet/SftpClient.cs

Line 2276 in 9f1699b

privateIEnumerable<ISftpFile>InternalListDirectory(stringpath,Action<int>listCallback)

SSH.NET/src/Renci.SshNet/Sftp/SftpSession.cs

Line 1196 in 9f1699b

publicKeyValuePair<string,SftpFileAttributes>[]RequestReadDir(byte[]handle)

SSH.NET/src/Renci.SshNet/Sftp/Responses/SftpNameResponse.cs

Lines 27 to 44 in 9f1699b

	protectedoverridevoidLoadData()
	{
	base.LoadData();
	Count=ReadUInt32();
	Files=newKeyValuePair<string,SftpFileAttributes>[Count];
	for(vari=0;i<Count;i++)
	{
	varfileName=ReadString(Encoding);
	if(SupportsLongName(ProtocolVersion))
	{
	_=ReadString(Encoding);// skip longname
	}
	Files[i]=newKeyValuePair<string,SftpFileAttributes>(fileName,ReadAttributes());
	}
	}

It looks fine to me.

[Rob-Hague]

Also seen in #1220

 Failed Create_directory_with_contents_and_list_it [128 ms]
Error Message:
Assert.AreEqual failed. Expected:</home/sshnet/sshnet-test/. False True
/home/sshnet/sshnet-test/.. False True
/home/sshnet/sshnet-test/test-file.txt True False
>. Actual:</home/sshnet/sshnet-test/.. False True
/home/sshnet/sshnet-test/test-file.txt True False
/home/sshnet/sshnet-test/. False True
>. Stack Trace:
at Renci.SshNet.IntegrationTests.SftpClientTests.Create_directory_with_contents_and_list_it() in /home/appveyor/projects/ssh-net/test/Renci.SshNet.IntegrationTests/SftpClientTests.cs:line 48
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

[WojciechNagorski]

It is strange, but I've just got the same error ;)

[WojciechNagorski]

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1