Skip to content

Use shared Data folder for client keys in integration tests - #1219

Merged
drieseng merged 7 commits into
sshnet:developfrom
Rob-Hague:testkeys
Nov 12, 2023
Merged

Use shared Data folder for client keys in integration tests#1219
drieseng merged 7 commits into
sshnet:developfrom
Rob-Hague:testkeys

Conversation

@Rob-Hague

Copy link
Copy Markdown
Collaborator

And some related test changes (see the commit messages for details). These changes make my life easier in some related feature development.

@Rob-Hague

Copy link
Copy Markdown
CollaboratorAuthor

@drieseng@WojciechNagorski could you kindly review/merge these test changes? It helps me with some work related to certificates.

The context is, there can be lots of combinations of keys used to create certificates. It would be cumbersome to generate and test certificates independently for the unit and integration test projects.

The other commits are to remove friction in working with the test keys with various tools

Change the data to be in 64-wide columns instead of 70, and add a newline
at the end of the file. ssh-keygen does not like it otherwise.
puttygen Key.OPENSSH.ECDSA.Encrypted.txt -O private-openssh-new -C Key.OPENSSH.ECDSA.Encrypted
puttygen Key.OPENSSH.ECDSA.txt -O private-openssh-new -C Key.OPENSSH.ECDSA
puttygen Key.OPENSSH.ECDSA384.Encrypted.txt -O private-openssh-new -C Key.OPENSSH.ECDSA384.Encrypted
puttygen Key.OPENSSH.ECDSA384.txt -O private-openssh-new -C Key.OPENSSH.ECDSA384
puttygen Key.OPENSSH.ECDSA521.Encrypted.txt -O private-openssh-new -C Key.OPENSSH.ECDSA521.Encrypted
puttygen Key.OPENSSH.ECDSA521.txt -O private-openssh-new -C Key.OPENSSH.ECDSA521
puttygen Key.OPENSSH.ED25519.Encrypted.txt -O private-openssh-new -C Key.OPENSSH.ED25519.Encrypted
puttygen Key.OPENSSH.ED25519.txt -O private-openssh-new -C Key.OPENSSH.ED25519
puttygen Key.OPENSSH.RSA.Encrypted.txt -O private-openssh-new -C Key.OPENSSH.RSA.Encrypted
puttygen Key.OPENSSH.RSA.txt -O private-openssh-new -C Key.OPENSSH.RSA
(the -C flag changes the comment, otherwise puttygen refuses to do anything)
Generated with
puttygen Key.OPENSSH.ECDSA.Encrypted.txt -o Key.OPENSSH.ECDSA.Encrypted.pub -O public-openssh
puttygen Key.OPENSSH.ECDSA.txt -o Key.OPENSSH.ECDSA.pub -O public-openssh
puttygen Key.OPENSSH.ECDSA384.Encrypted.txt -o Key.OPENSSH.ECDSA384.Encrypted.pub -O public-openssh
puttygen Key.OPENSSH.ECDSA384.txt -o Key.OPENSSH.ECDSA384.pub -O public-openssh
puttygen Key.OPENSSH.ECDSA521.Encrypted.txt -o Key.OPENSSH.ECDSA521.Encrypted.pub -O public-openssh
puttygen Key.OPENSSH.ECDSA521.txt -o Key.OPENSSH.ECDSA521.pub -O public-openssh
puttygen Key.OPENSSH.ED25519.Encrypted.txt -o Key.OPENSSH.ED25519.Encrypted.pub -O public-openssh
puttygen Key.OPENSSH.ED25519.txt -o Key.OPENSSH.ED25519.pub -O public-openssh
puttygen Key.OPENSSH.RSA.Encrypted.txt -o Key.OPENSSH.RSA.Encrypted.pub -O public-openssh
puttygen Key.OPENSSH.RSA.txt -o Key.OPENSSH.RSA.pub -O public-openssh
and so forth. Some whose ciphers are unsupported by puttygen were generated with e.g.
sudo ssh-keygen -f Key.RSA.Encrypted.Des.CBC.12345.txt -y > Key.RSA.Encrypted.Des.CBC.12345.pub
@WojciechNagorski

Copy link
Copy Markdown
Collaborator

I will check it.

Comment threadtest/.editorconfig
@drieseng
drieseng merged commit 5ffcb94 into sshnet:developNov 12, 2023
@Rob-Hague
Rob-Hague deleted the testkeys branch November 12, 2023 16:04
@Rob-Hague

Copy link
Copy Markdown
CollaboratorAuthor

Thanks!

@WojciechNagorski

Copy link
Copy Markdown
Collaborator

@Rob-Hague Great job! @drieseng Thanks for review :)

@WojciechNagorskiWojciechNagorski added this to the 2023.0.1 milestone Nov 16, 2023
@WojciechNagorskiWojciechNagorski mentioned this pull request Dec 29, 2023
@WojciechNagorski

Copy link
Copy Markdown
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

This was referenced Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Rob-Hague@WojciechNagorski@drieseng