Skip to content

Add support for .NET 8.0 - #1255

Merged
WojciechNagorski merged 5 commits into
sshnet:developfrom
scott-xu:dotnet8
Dec 1, 2023
Merged

Add support for .NET 8.0#1255
WojciechNagorski merged 5 commits into
sshnet:developfrom
scott-xu:dotnet8

Conversation

@scott-xu

@scott-xuscott-xu commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@scott-xuscott-xu self-assigned this Dec 1, 2023
@scott-xu
scott-xu marked this pull request as ready for review December 1, 2023 14:46
@scott-xu

scott-xu commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Was going to add source link to SSH.NET and just found that it is included in the .NET 8 SDK and enabled by default.
This PR is only to add support for .NET 8.0. I can create another PR afterwards, to generate the symbol package.
Would you please kindly have a review? Thanks! @WojciechNagorski@drieseng

WojciechNagorski
WojciechNagorski requested changes Dec 1, 2023
View reviewed changes
Comment threadappveyor.yml Outdated
WojciechNagorski
WojciechNagorski approved these changes Dec 1, 2023
View reviewed changes

@WojciechNagorskiWojciechNagorski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@drieseng@Rob-Hague do you mind?

@Rob-Hague

Rob-Hague commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

It's fine for me. I'm not convinced we need a net8.0 target without using any .NET 8 features (other than throw helpers), but using the .NET 8 SDK for source-link is good 👍

@WojciechNagorski
WojciechNagorski merged commit 4c7bd35 into sshnet:developDec 1, 2023
@scott-xu
scott-xu deleted the dotnet8 branch December 1, 2023 23:23
@scott-xuscott-xu added this to the 2023.0.1 milestone Dec 1, 2023
@WojciechNagorskiWojciechNagorski mentioned this pull request Dec 29, 2023
Closed
@WojciechNagorski

WojciechNagorski commented Dec 29, 2023

Copy link
Copy Markdown
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

This was referenced Aug 12, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 12, 2026
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Merged
Open
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WojciechNagorskiWojciechNagorskiWojciechNagorski approved these changes
@driesengdriesengAwaiting requested review from driesengdrieseng is a code owner
@Rob-HagueRob-HagueAwaiting requested review from Rob-HagueRob-Hague is a code owner

Assignees

@scott-xuscott-xu

Labels

None yet

Projects

None yet

Milestone

2023.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@scott-xu@Rob-Hague@WojciechNagorski