Uh oh!
There was an error while loading. Please reload this page.
Remove feature binary serialization - #1325
Merged
WojciechNagorski merged 4 commits intoMar 5, 2024
Merged
Conversation
scott-xu
commented
Feb 17, 2024
CollaboratorAuthor
Close this PR based on https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/binaryformatter-obsoletion.md |
Rob-Hague
commented
Feb 17, 2024
Collaborator
I think we should keep it as it is. You can replace |
scott-xu
commented
Feb 17, 2024
CollaboratorAuthor
Good suggestion. |
scott-xuforce-pushed
the
remove-FEATURE_BINARY_SERIALIZATION
branch
from
February 17, 2024 10:01
09365c2 to
c447a84Comparescott-xu
marked this pull request as ready for review
February 18, 2024 04:29
Rob-Hague
approved these changes
Mar 4, 2024
This was referenced Aug 12, 2026
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constant FEATURE_BINARY_SERIALIZATION was to help build with .NET Standard 1.3.
Since current all target frameworks support Serialization, we don't need this flag anymore.
See cf85100?diff=split&w=0#diff-e4b38dd57f5fc1250fafcccb6ba71f914244bb03755abeea94cbfc0ea4bbbc90L44
branch scott-xu:remove-FEATURE_BINARY_SERIALIZATION is based on scott-xu:drop-RIPEMD160