Skip to content

enable nullable on BaseClient and SftpClient - #1339

Merged
Rob-Hague merged 2 commits into
sshnet:developfrom
mus65:sftpclientnullable
Apr 17, 2024
Merged

enable nullable on BaseClient and SftpClient#1339
Rob-Hague merged 2 commits into
sshnet:developfrom
mus65:sftpclientnullable

Conversation

@mus65

@mus65mus65 commented Feb 24, 2024

Copy link
Copy Markdown
Contributor

This is just a start to get some feedback, I could do more of the public APIs.

Rob-Hague
Rob-Hague reviewed Mar 4, 2024
View reviewed changes
Comment threadsrc/Renci.SshNet/ISftpClient.cs Outdated
Rob-Hague
Rob-Hague reviewed Mar 4, 2024
View reviewed changes
Comment threadsrc/Renci.SshNet/SftpClient.cs Outdated
Rob-Hague
Rob-Hague reviewed Mar 4, 2024
View reviewed changes
Comment threadsrc/Renci.SshNet/SftpClient.cs Outdated
@mus65
mus65force-pushed the sftpclientnullable branch from effb908 to fd605c4CompareMarch 5, 2024 16:53
Rob-Hague
Rob-Hague approved these changes Mar 5, 2024
View reviewed changes

@Rob-HagueRob-Hague left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

For future reference, it is easier if you can avoid force-pushing once a review has started (merge develop into the PR branch to fix conflicts if possible). Then the new changes can more easily be seen

@Rob-Hague
Rob-Hague merged commit 4cab7e5 into sshnet:developApr 17, 2024
@mus65mus65 mentioned this pull request May 5, 2024
Merged
@mus65
mus65 deleted the sftpclientnullable branch September 14, 2024 09:30
@dependabotdependabotBot mentioned this pull request Oct 30, 2025
Merged
This was referenced Aug 12, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 12, 2026
Open
Open
Closed
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Merged
Open
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rob-HagueRob-HagueRob-Hague approved these changes
@driesengdriesengAwaiting requested review from driesengdrieseng is a code owner
@WojciechNagorskiWojciechNagorskiAwaiting requested review from WojciechNagorskiWojciechNagorski is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mus65@Rob-Hague