Skip to content

Fix CancelAsync Cause Deadlock - #1345

Merged
WojciechNagorski merged 9 commits into
sshnet:developfrom
zeotuan:cancelAsync
Mar 24, 2024
Merged

Fix CancelAsync Cause Deadlock#1345
WojciechNagorski merged 9 commits into
sshnet:developfrom
zeotuan:cancelAsync

Conversation

@zeotuan

@zeotuanzeotuan commented Mar 7, 2024•
edited by Rob-Hague
Loading

Copy link
Copy Markdown
Contributor

Fix CancelAsync causing deadlocking:

it now signal WaitHandle of Cancelled event after sending SIGTERM/SIGKILL signal to try to abort the request.

close#1147 and close#1023

@zeotuan
zeotuan marked this pull request as ready for review March 7, 2024 02:14
@zeotuanzeotuan mentioned this pull request Mar 7, 2024
Closed
Rob-Hague
Rob-Hague reviewed Mar 11, 2024
View reviewed changes

@Rob-HagueRob-Hague left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test for forceKill = true as well?

Comment threadtest/Renci.SshNet.IntegrationTests/OldIntegrationTests/SshCommandTest.cs Outdated
Comment threadtest/Renci.SshNet.IntegrationTests/OldIntegrationTests/SshCommandTest.cs Outdated
Comment threadsrc/Renci.SshNet/SshCommand.cs Outdated
Comment threadsrc/Renci.SshNet/SshCommand.cs
/// </summary>
public void CancelAsync()
/// <param name="forceKill">if true send SIGKILL instead of SIGTERM.</param>
public void CancelAsync(bool forceKill = false)

@Rob-HagueRob-HagueMar 11, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we drop the Async suffix here (and obsolete CancelAsync) as it is not an async method. @WojciechNagorski?

@zeotuan
zeotuan requested a review from Rob-HagueMarch 21, 2024 22:55
Rob-Hague
Rob-Hague reviewed Mar 23, 2024
View reviewed changes
Comment threadsrc/Renci.SshNet/SshCommand.cs Outdated
Rob-Hague
Rob-Hague reviewed Mar 23, 2024
View reviewed changes
Comment threadsrc/Renci.SshNet/Common/SshOperationCancelledException.cs Outdated
WojciechNagorski
WojciechNagorski approved these changes Mar 24, 2024
View reviewed changes

@WojciechNagorskiWojciechNagorski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't have much time for this project at the moment. Only PRs that have @Rob-Hague's approval are verified and merged by me.

@WojciechNagorski
WojciechNagorski merged commit db3d7e8 into sshnet:developMar 24, 2024
@Rob-HagueRob-Hague mentioned this pull request May 17, 2024
Merged
@Rob-HagueRob-Hague mentioned this pull request Jun 5, 2024
Merged
@dependabotdependabotBot mentioned this pull request Oct 30, 2025
Merged
This was referenced Aug 12, 2026
Open
Open
Open
Open
Open
Open
This was referenced Aug 12, 2026
Open
Open
Closed
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Merged
Open
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rob-HagueRob-HagueRob-Hague approved these changes
@WojciechNagorskiWojciechNagorskiWojciechNagorski approved these changes
@driesengdriesengAwaiting requested review from driesengdrieseng is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CancelAsync does not cancel the command started by BeginExecute and blocks execution Is it possible to cancel SshCommand?

3 participants

@zeotuan@Rob-Hague@WojciechNagorski