Skip to content

Use ExceptionDispatchInfo to retain call stack in AsyncResult.EndInvoke()#1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rob-Hague merged 2 commits into from
Aug 12, 2024
Merged

Use ExceptionDispatchInfo to retain call stack in AsyncResult.EndInvoke() #1470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
386b439
Use ExceptionDispatchInfo to retain call stack in AsyncResult.EndInvo…
scott-xu Aug 11, 2024
1663bf4
Merge branch 'develop' into ExceptionDispatchInfo
scott-xu Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Renci.SshNet/Common/AsyncResult.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
using System;
using System.Runtime.ExceptionServices;
using System.Threading;

namespace Renci.SshNet.Common
Expand DownExpand Up@@ -85,7 +86,7 @@ internal void EndInvoke()
// Operation is done: if an exception occurred, throw it
if (_exception != null)
{
throw _exception;
ExceptionDispatchInfo.Capture(_exception).Throw();
}
}

Expand Down