Uh oh!
There was an error while loading. Please reload this page.
Add .NET 9 target - #1480
Conversation
This following change in the runtime now causes this analyzer to complain about some Debug.Assert calls which doesn't make sense. https://github.com/dotnet/core/blob/main/release-notes/9.0/preview/preview7/libraries.md#debugassert-now-reports-assert-condition-by-defaulthttps://rules.sonarsource.com/csharp/RSPEC-3236/
Rob-Hague
commented
Aug 31, 2024
Can we have a basic Lock polyfill to save on the #ifdefs? e.g. #if !NET9_0_OR_GREATERnamespaceRenci.SshNet.Common;internalsealedclassLock{publicboolTryEnter()=>Monitor.TryEnter(this);publicvoidExit()=>Monitor.Exit(this);} |
mus65
commented
Aug 31, 2024
Makes sense, pushed. |
drieseng
commented
Sep 13, 2024
@mus65, you'll also want to update global.json. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
drieseng
commented
Sep 13, 2024
@Rob-Hague, are planning on merging this before the release of .NET 9.0? In theory, there may even be API changes - I'm thinking of the Lock class - between now and the release. It's highly unlikely though. |
mus65
commented
Sep 14, 2024
@drieseng@Rob-Hague I updated global.json . I had to reference RC1 explicitly though, so I have to change it when final is released. I left it a draft because it's still preview and wouldn't expect it to be merged before .NET 9 final. RC1 is already released, so I wouldn't expect any more API changes. |
Rob-Hague
commented
Sep 14, 2024
Yeah, we will merge once .NET 9 is released Newer targets can be used on appveyor with apt-get, as in the opposite of #1352 |
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
for some reason this happens starting with .NET 9.0 RC2: /home/mus/git/SSH.NET/test/Renci.SshNet.IntegrationTests/Renci.SshNet.IntegrationTests.csproj : error NU1605: Warning As Error: Detected package downgrade: BouncyCastle.Cryptography from 2.4.0 to 2.3.1. Reference the package directly from the project to select a different version. Renci.SshNet.IntegrationTests -> SSH.NET 1.0.0 -> BouncyCastle.Cryptography (>= 2.4.0) Renci.SshNet.IntegrationTests -> Testcontainers 3.10.0 -> BouncyCastle.Cryptography (>= 2.3.1)
mus65
commented
Nov 13, 2024
This is now only blocked by AppVeyor not supporting .NET 9. apt-get is not going work either because the dotnet9 package is not available in Ubuntu 22.04 (see https://launchpad.net/ubuntu/+source/dotnet9 ). @Rob-Hague has there been any thought about moving to GitHub actions? |
Rob-Hague
commented
Nov 13, 2024
I seem to remember @WojciechNagorski trying it but I can't find a PR so may be imagining |
Rob-Hague
commented
Nov 13, 2024
Feel free to give a go though |
I had to disable a SonarSource analyzer and made use of the new
Locktype, see separate Commits.CI is expected to fail because of missing .NET 9 binaries in AppVeyor. Build and tests pass locally.
Can be merged when .NET 9 final is released and AppVeyor supports it.