Uh oh!
There was an error while loading. Please reload this page.
[Private Key] Add support for PuTTY private key file format (V3 and V2) - #1543
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| switch (keyType) | ||
| { | ||
| case "ssh-ed25519": | ||
| parsedKey = new ED25519Key(privateKeyReader.ReadBignum2()); |
There was a problem hiding this comment.
ED25519Key class does not have a constructor with bothpublicKeyData and privateKeyData. The current implementation is to generate public key from private key. Should we add a new constructor?
SSH.NET/src/Renci.SshNet/Security/Cryptography/ED25519Key.cs
Lines 98 to 104 in 3ec45e1
There was a problem hiding this comment.
it seems ok as it is, but I don't mind
Rob-Hague
left a comment
There was a problem hiding this comment.
lgtm, will wait for a stable BC release
Uh oh!
There was an error while loading. Please reload this page.
| switch (keyType) | ||
| { | ||
| case "ssh-ed25519": | ||
| parsedKey = new ED25519Key(privateKeyReader.ReadBignum2()); |
There was a problem hiding this comment.
it seems ok as it is, but I don't mind
Uh oh!
There was an error while loading. Please reload this page.
7e5d67f to
05547daCompareRob-Hague
commented
Dec 2, 2024
ooh a flaky test |
This PR adds support for PuTTY private key file format (V3 and V2) described in https://tartarus.org/~simon/putty-snapshots/htmldoc/AppendixC.html
Close#341
Close#431
Close#434
Close#510
Notes:
It may subject to change, then we need to change accordingly. (Hope not). Also hope BouncyCastle makes a formal release before SSH.NET next release.Update: BouncyCastle 2.5.0 is released.