Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 994
Update docs and remove a leftover DSA certificate algorithm#1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,3 +4,5 @@ | ||
| href: examples.md | ||
| - name: API | ||
| href: api/ | ||
| - name: Logging | ||
| href: logging.md | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -28,9 +28,6 @@ namespace Renci.SshNet | ||
| /// <description>RSA in OpenSSL PEM, ssh.com, OpenSSH and PuTTY key format</description> | ||
| /// </item> | ||
| /// <item> | ||
| /// <description>DSA in OpenSSL PEM, ssh.com and PuTTY key format</description> | ||
| /// </item> | ||
| /// <item> | ||
| /// <description>ECDSA 256/384/521 in OpenSSL PEM, OpenSSH and PuTTY key format</description> | ||
| /// </item> | ||
| /// <item> | ||
| @@ -321,7 +318,6 @@ private void Open(Stream privateKey, string? passPhrase) | ||
| switch (keyName) | ||
| { | ||
| case "RSA PRIVATE KEY": | ||
| case "DSA PRIVATE KEY": | ||
CollaboratorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this removal makes no difference, it throws NotSupportedException either way | ||
| case "EC PRIVATE KEY": | ||
| var cipherName = privateKeyMatch.Result("${cipherName}"); | ||
| var salt = privateKeyMatch.Result("${salt}"); | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2025.0.0 will break with servers which offer
ssh-dss-cert-v01@openssh.combecause I missed this line in #1558. Hopefully that is not very many... the workaround is to remove it:client.ConnectionInfo.HostKeyAlgorithms.Remove("ssh-dss-cert-v01@openssh.com");