Uh oh!
There was an error while loading. Please reload this page.
Add UploadFileAsync and DownloadFileAsync methods - #1634
Conversation
Uh oh!
There was an error while loading. Please reload this page.
sdt-ndelarosa
commented
Apr 24, 2025
actions don't seem to be triggering, gonna try closing and reopening |
Rob-Hague
commented
Apr 25, 2025
Hi, I will make time to review most likely at some point next week. FYI for first time contributors the CI needs to be run manually (some kind of github security measure) |
Rob-Hague
left a comment
There was a problem hiding this comment.
Looks good. I think it could do with testing cancellation - i.e. that it throws OperationCanceledException when the token is cancelled.
It would probably not be very reliable to test cancelling during a file download (at least not in an integration test), but we could at least have a test for when a cancelled token is supplied
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Adds TAP methods for
UploadFileandDownloadFiletoISftpClient.Other Solutions
While there are other options to define both the
UploadFileAsyncandDownloadFileAsyncmethods, such as the extension methods approach and the previously proposed pull request, #1515 , this pull request has the following benefits over the other solutions:UploadFileandDownloadFilemethodsBeginUploadFile, which pretty much runs the sync UploadFile method, but just in a different thread