Uh oh!
There was an error while loading. Please reload this page.
feat(ci): surface failing-job root cause in the PR failure comment - #441
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Add checks:read to the report job so the annotations lookup succeeds instead of always falling back to the log tail, and note in the action-pins remediation comment that the suggested edit assumes the Dependabot bump direction. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
drift-comment.yamlcompanion reported only the workflow-drift job. When another gated job fails (for example Unit Tests, where the action-pins consistency-guard failures land), the PR showed a red gate with no inline explanation and a maintainer had to open the run logs.Fix
Extend the single existing
workflow_runcompanion (renamed display name to "PR Failure Report"; no second workflow, which would race and double-comment) to:TestWorkflowsConsistentWithActionPins/TestActionPinsAnchorCoversManifest): parse the want/got rows and print the exactinternal/generate/action_pins.yamledit so the reader gets the fix without opening logs.head_shaguard so an out-of-orderworkflow_runcompletion for a superseded commit cannot overwrite a newer comment.Permissions stay
permissions: {}top-level with job-levelpull-requests: write+actions: read(needed to read the triggering run's jobs, annotations, and logs).Verification
actionlintclean on the changed workflow.node --check.go build ./...andgo test ./internal/generateclean (no Go changed).Closes#437