Skip to content

feat: Add vendor label to deployed third-party resources - #9

Merged
Techassi merged 8 commits into
mainfrom
feat/labels
Feb 2, 2024
Merged

feat: Add vendor label to deployed third-party resources#9
Techassi merged 8 commits into
mainfrom
feat/labels

Conversation

@Techassi

@TechassiTechassi commented Dec 18, 2023

Copy link
Copy Markdown
Member

@TechassiTechassi self-assigned this Dec 18, 2023
@TechassiTechassi mentioned this pull request Jan 30, 2024
Closed
@TechassiTechassi changed the title feat: Add labels to deployed resourcesfeat: Add vednor label to deployed resourcesJan 30, 2024
@TechassiTechassi changed the title feat: Add vednor label to deployed resourcesfeat: Add vendor label to deployed resourcesJan 30, 2024
@Techassi
Techassi marked this pull request as ready for review January 30, 2024 10:10
@adwk67
adwk67 self-requested a review January 30, 2024 12:24
adwk67
adwk67 requested changes Jan 30, 2024
View reviewed changes

@adwk67adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few places where values do not get "passed through" but I guess these are largely out of our control.

Comment threadstacks/airflow/airflow.yaml Outdated
Comment threadstacks/_templates/minio.yaml
Comment threadstacks/_templates/opensearch-dashboards.yaml
Comment threadstacks/_templates/prometheus-service-monitor.yaml
Comment threadstacks/_templates/prometheus-service-monitor.yaml
Comment threadstacks/_templates/prometheus.yaml
Comment threadstacks/_templates/postgresql-timescaledb.yaml Outdated
Comment threadstacks/_templates/postgresql-timescaledb.yaml
Comment threadstacks/signal-processing/jupyterhub.yaml Outdated
Comment threadstacks/_templates/jupyterhub.yaml Outdated
sbernauer
sbernauer reviewed Feb 1, 2024
View reviewed changes
Comment threaddemos/data-lakehouse-iceberg-trino-spark/create-spark-ingestion-job.yaml
@Techassi

Techassi commented Feb 1, 2024

Copy link
Copy Markdown
MemberAuthor

Removed all vendor labels from the demo/stack manifests as discussed in today's (2024-02-01) meeting.

@TechassiTechassi changed the title feat: Add vendor label to deployed resourcesfeat: Add vendor label to deployed third-party resourcesFeb 1, 2024
adwk67
adwk67 approved these changes Feb 1, 2024
View reviewed changes

@adwk67adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. There are still some labels that do not get passed through but not much we can do about that: the main thing is that the errors are gone. Thanks!

sbernauer
sbernauer approved these changes Feb 2, 2024
View reviewed changes

@sbernauersbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Comment threaddemos/nifi-kafka-druid-water-level-data/create-druid-ingestion-job.yaml
@Techassi
Techassi added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit b1b0933Feb 2, 2024
@Techassi
Techassi deleted the feat/labels branch February 2, 2024 08:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67adwk67adwk67 approved these changes
@sbernauersbernauersbernauer approved these changes

Assignees

@TechassiTechassi

Labels

release/24.3.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Techassi@adwk67@sbernauer@lfrancke