Skip to content
This repository was archived by the owner on Jul 15, 2026. It is now read-only.

feat: Add universal navigation bar - #149

Merged
xeniape merged 2 commits into
stackablefrom
feat/add-universal-header
Jul 2, 2026
Merged

feat: Add universal navigation bar#149
xeniape merged 2 commits into
stackablefrom
feat/add-universal-header

Conversation

@xeniape

@xeniapexeniape commented Jun 29, 2026

Copy link
Copy Markdown
Member

This PR adds the universal navigation bar, similar to the one in the HUB, mimicking its design and functionality, but adjusted some minor things compared to the HUB version:

  • GitHub link opens in a new tab (since it does not have the navigation bar to navigate back)
  • Clicking outside of the drop down menu, closes it
  • If the drop down menu is open and screen size changes to the desktop version, it does not display the lingering drop down menu
  • Change "Docs" menu item names to "Documentation"
  • Remove grey host labels from menu items in desktop version

@xeniapexeniape self-assigned this Jun 29, 2026
@xeniapexeniape moved this to Development: Waiting for Review in Stackable EngineeringJun 29, 2026
@NickLarsenNZ

Copy link
Copy Markdown
Member

Do you have a screenshot available? Or can it be deployed somewhere?

@xeniape

Copy link
Copy Markdown
MemberAuthor

Do you have a screenshot available? Or can it be deployed somewhere?

If it's not too much to ask I would prefer if you could build it and try it out (to catch things that don't work). For that you would go into the documentation repository, create a symlink ui to the local checkouted branch here (move the git module temporarily), and use the make build-truly-local command. But I can also attach a screenshot in a bit.

@xeniape

Copy link
Copy Markdown
MemberAuthor
imageimage

Basically the same as in https://hub.stackable.tech/ but with the adjustments mentioned above

Comment threadsrc/partials/universal-nav.hbs
Comment threadsrc/partials/universal-nav.hbs Outdated
Comment threadsrc/partials/universal-nav.hbs
<div class="universal-nav" role="region" aria-label="Stackable network">
<div class="universal-nav__bar">
<a class="universal-nav__brand" href="{{{ relativize (versioned "home" page "index.html") }}}" aria-label="Stackable Documentation home">
<img class="universal-nav__logo" src="{{{uiRootPath}}}/img/stackable-mark.svg" alt="">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this right above the logo of the docs header looks really weird/overloaded. I would remove one of the two (most likely the one from the docs header as this universal nav bar seems to be the way forward).

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but would do that as part of another PR to keep the scope about the universal header only.

@xeniape
xeniape requested a review from TechassiJuly 1, 2026 10:03

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on resolved comments.

@xeniape
xeniape merged commit d72dc30 into stackableJul 2, 2026
2 checks passed
@xeniape
xeniape deleted the feat/add-universal-header branch July 2, 2026 11:09
@NickLarsenNZNickLarsenNZ moved this from Development: Waiting for Review to Development: Done in Stackable EngineeringJul 2, 2026
@lfranckelfrancke moved this from Development: Done to Done in Stackable EngineeringJul 6, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

@xeniape@NickLarsenNZ@Techassi@stackfab@lfrancke