Skip to content

ADR on trino catalogs - #196

Merged
nightkr merged 12 commits into
mainfrom
adr-trino-catalogs
May 18, 2022
Merged

ADR on trino catalogs#196
nightkr merged 12 commits into
mainfrom
adr-trino-catalogs

Conversation

@sbernauer

@sbernauersbernauer commented May 17, 2022•
edited
Loading

Copy link
Copy Markdown
Member

We still need a decision on both ADRs
Decison finished, can be presented in Arch meeting on Wednesday.

@sbernauer
sbernauer marked this pull request as draft May 17, 2022 08:40
@sbernauer

sbernauer commented May 17, 2022

Copy link
Copy Markdown
MemberAuthor

Adopted to decision in meeting today. Can be presented in Arch meeting on Wednesday.

@sbernauer
sbernauer marked this pull request as ready for review May 17, 2022 11:13
nightkr
nightkr previously approved these changes May 17, 2022
View reviewed changes
Comment threadmodules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment threadmodules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
sbernauerand others added 2 commits May 17, 2022 14:06
@sbernauer@nightkr
Update modules/contributor/pages/adr/ADR019-trino_catalog_definitions…
0f34d5c
….adoc
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
@sbernauer@nightkr
Update modules/contributor/pages/adr/ADR019-trino_catalog_definitions…
f54cbf1
….adoc
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
@sbernauer

sbernauer commented May 17, 2022

Copy link
Copy Markdown
MemberAuthor

thx!
Could you please merge it when you have presented it tomorrow?

maltesander
maltesander reviewed May 17, 2022
View reviewed changes

@maltesandermaltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some spelling.

Comment threadmodules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment threadmodules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment threadmodules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment threadmodules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment threadmodules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment threadmodules/contributor/pages/adr/ADR020-trino_catalog_usage.adoc Outdated
Comment threadmodules/contributor/pages/adr/ADR020-trino_catalog_usage.adoc Outdated
sbernauerand others added 7 commits May 18, 2022 08:28
@sbernauer@maltesander
Update modules/contributor/pages/adr/ADR019-trino_catalog_definitions…
28d34d9
….adoc
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer@maltesander
Update modules/contributor/pages/adr/ADR019-trino_catalog_definitions…
37c401f
….adoc
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer@maltesander
Update modules/contributor/pages/adr/ADR019-trino_catalog_definitions…
603f738
….adoc
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer@maltesander
Update modules/contributor/pages/adr/ADR019-trino_catalog_definitions…
d5c2c4e
….adoc
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer@maltesander
Update modules/contributor/pages/adr/ADR019-trino_catalog_definitions…
9d3d992
….adoc
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer@maltesander
Update modules/contributor/pages/adr/ADR020-trino_catalog_usage.adoc
4746a32
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer@maltesander
Update modules/contributor/pages/adr/ADR020-trino_catalog_usage.adoc
e0aed42
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@maltesander

maltesander commented May 18, 2022

Copy link
Copy Markdown
Member

We fine with merging this @teozkr@soenkeliebau ?

@nightkr

nightkr commented May 18, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

I suppose the remaining bit here would be the arch meeting presentation @maltesander.

@maltesander

maltesander commented May 18, 2022

Copy link
Copy Markdown
Member

I suppose the remaining bit here would be the arch meeting presentation @maltesander.

true ;)

nightkr
nightkr approved these changes May 18, 2022
View reviewed changes

@nightkrnightkr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@nightkr
nightkr merged commit 8bca58c into mainMay 18, 2022
@nightkr
nightkr deleted the adr-trino-catalogs branch May 18, 2022 13:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesandermaltesandermaltesander left review comments
@soenkeliebausoenkeliebauAwaiting requested review from soenkeliebau
+1 more reviewer
@nightkrnightkrnightkr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer@maltesander@nightkr