Skip to content

Refactoring Service Discovery Concept text - #215

Merged
fhennig merged 23 commits into
mainfrom
service-discovery-refactoring
Jun 23, 2022
Merged

Refactoring Service Discovery Concept text#215
fhennig merged 23 commits into
mainfrom
service-discovery-refactoring

Conversation

@fhennig

@fhennigfhennig commented Jun 16, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

closes#86

@fhennig
fhennig marked this pull request as ready for review June 16, 2022 12:10
razvan
razvan reviewed Jun 16, 2022
View reviewed changes

@razvanrazvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas

Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
fhennigand others added 8 commits June 20, 2022 09:46
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
8408dc6
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
6e62361
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
d95a87f
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Felix Hennig
more/different text
b26319a
@fhennig
Merge branch 'main' into service-discovery-refactoring
14116d3
Felix Hennig
New text
7834dca
Felix Hennig
Merge branch 'service-discovery-refactoring' of github.com:stackablet…
9dc8734
…ech/documentation into service-discovery-refactoring
Felix Hennig
Minor changes
2af33e8
razvan
razvan reviewed Jun 23, 2022
View reviewed changes

@razvanrazvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puh, writing docs is hard. I made some suggestions mostly related to form not content.

Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
Comment threadmodules/contributor/pages/service_discovery.adoc Outdated
fhennigand others added 8 commits June 23, 2022 15:19
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
58b1700
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
be6b4b8
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
8c52c34
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/contributor/pages/service_discovery.adoc
5b2ce08
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
c8df4dc
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
3fbb2e5
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Felix Hennig
Changes
fa22a41
Felix Hennig
Added link to druid
f339938
@fhennig
fhennig requested a review from razvanJune 23, 2022 14:18
@fhennig

fhennig commented Jun 23, 2022

Copy link
Copy Markdown
ContributorAuthor

I've added a first paragraph that already gives an overview, I've moved a lot of text into a "Motivation" section to clarify that. I've added some more details to the usage, in an effort to make it clearer. The second sub-paragraph under usage could probably use an example, but I couldn't come up with a good, compact example.

razvan
razvan reviewed Jun 23, 2022
View reviewed changes
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
razvan
razvan reviewed Jun 23, 2022
View reviewed changes
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
razvan
razvan reviewed Jun 23, 2022
View reviewed changes
Comment threadmodules/concepts/pages/service_discovery.adoc Outdated
razvan
razvan previously approved these changes Jun 23, 2022
View reviewed changes

@razvanrazvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
3625c37
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
fhennigand others added 2 commits June 23, 2022 16:55
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
80a0fe6
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig@razvan
Update modules/concepts/pages/service_discovery.adoc
9d41ce3
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
razvan
razvan approved these changes Jun 23, 2022
View reviewed changes

@razvanrazvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@fhennig
fhennig merged commit 14f3a3d into mainJun 23, 2022
@fhennig
fhennig deleted the service-discovery-refactoring branch June 23, 2022 15:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvanrazvanrazvan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for how service discovery works

2 participants

@fhennig@razvan