Uh oh!
There was an error while loading. Please reload this page.
fix: Move pagefind assets back to /pagefind to fix broken search - #892
Merged
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#883 moved the pagefind bundle from
/pagefind/to/_/pagefind/so its requests would match the asset rate-limit rule. But pagefind derives its result baseUrl by stripping the/pagefind/suffix off the bundle path. With the bundle at/_/pagefind/, the derived baseUrl became/_/, which got prepended to every search result URL.Rate limiting was removed entirely in #885, so #883 no longer serves any purpose. This reverts the bundle back to
/pagefind/.