Skip to content

feat(template): Support registry-specific Helm values - #583

Merged
Techassi merged 5 commits into
mainfrom
feat/template-registry-specific-values
Apr 20, 2026
Merged

feat(template): Support registry-specific Helm values#583
Techassi merged 5 commits into
mainfrom
feat/template-registry-specific-values

Conversation

@Techassi

@TechassiTechassi commented Apr 10, 2026

Copy link
Copy Markdown
Member

@TechassiTechassi self-assigned this Apr 10, 2026
@TechassiTechassi mentioned this pull request Apr 10, 2026
Merged
@TechassiTechassi moved this to Development: Waiting for Review in Stackable EngineeringApr 13, 2026
NickLarsenNZ
NickLarsenNZ requested changes Apr 20, 2026
View reviewed changes

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of missing interpolations, otherwise good

Comment threadtemplate/Makefile.j2 Outdated
Comment threadtemplate/deploy/helm/[[operator]]/values/oci.stackable.tech.yaml Outdated
NickLarsenNZ
NickLarsenNZ approved these changes Apr 20, 2026
View reviewed changes

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TechassiTechassi moved this from Development: Waiting for Review to Development: In Review in Stackable EngineeringApr 20, 2026
@Techassi
Techassi added this pull request to the merge queueApr 20, 2026
Merged via the queue into main with commit b578bafApr 20, 2026
2 checks passed
@Techassi
Techassi deleted the feat/template-registry-specific-values branch April 20, 2026 07:21
@TechassiTechassi moved this from Development: In Review to Development: Done in Stackable EngineeringApr 20, 2026
@TechassiTechassi mentioned this pull request Apr 21, 2026
Merged
@lfranckelfrancke moved this from Development: Done to Done in Stackable EngineeringMay 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZNickLarsenNZNickLarsenNZ approved these changes

Assignees

@TechassiTechassi

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Techassi@NickLarsenNZ@lfrancke