Skip to content

ci: fix the security audit, and bump every pinned action - #2

Merged
maltesander merged 1 commit into
mainfrom
ci/update-github-actions
Aug 5, 2026
Merged

ci: fix the security audit, and bump every pinned action#2
maltesander merged 1 commit into
mainfrom
ci/update-github-actions

Conversation

@maltesander

Copy link
Copy Markdown
Member

Description

The nightly audit failed because rustsec/audit-check falls back to a bare
cargo install cargo-audit when the binary is not on PATH. That fallback
passes no --locked, so it pulls in dependencies needing a newer rustc than
our 1.95.0 pin. Installing a prebuilt binary first avoids the compile.

The job also ran with contents: read alone, so audit-check could neither
open the advisory issue nor record the check run. On a cron trigger that is
the only reporting path, so it could go green while saying nothing.

Every other pinned action moves to its current release:

actionfromto
actions/checkoutv5.0.0v7.0.1
actions/download-artifactv4.3.0v8.0.1
actions/upload-artifactv4.6.2v7.0.1
actions/setup-pythonv5.6.0v7.0.0
astral-sh/setup-uvv8.0.0v9.0.0
softprops/action-gh-releasev2.3.2v3.0.2
Swatinem/rust-cachev2.8.0v2.9.1
taiki-e/install-actionv2.75.4v2.85.8
awalsh128/cache-apt-pkgs-actionv1.6.0v1.6.3
github/codeql-action/upload-sarifv3.37.4v3.37.6

`rustsec/audit-check` falls back to a bare `cargo install cargo-audit`
when the binary is not on PATH. That fallback passes no `--locked`, so it
resolves cargo-audit's dependencies fresh and pulls in versions needing a
newer rustc than the 1.95.0 that rust-toolchain.toml pins. Installing a
prebuilt binary first satisfies the PATH lookup, so the action never
compiles cargo-audit.
The job also ran with `contents: read` alone, so audit-check could
neither open the advisory issue nor record the check run. On a cron
trigger that is the only reporting path, so it could go green while
saying nothing.
Every other pinned action moves to its current release.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@maltesander
maltesander requested a review from adwk67August 5, 2026 09:27
@maltesandermaltesander self-assigned this Aug 5, 2026

@adwk67adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
maltesander merged commit 9d5ba03 into mainAug 5, 2026
6 checks passed
@maltesander
maltesander deleted the ci/update-github-actions branch August 5, 2026 09:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maltesander@adwk67