Uh oh!
There was an error while loading. Please reload this page.
feat: add progress reporting - #376
Conversation
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Really nice. Here's some initial feedback.
I noticed a lot of formatting changes, but I couldn't tell if it was new or old styling.
I also see pre-commit failed, so could be related.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
```shell cargo +nightly-2025-01-15 fmt --all ```
…d use span filtering toc ontrol indicatif output NOTE: Use `fields(indicatif.pb_show = true)` on instrumented functions that should have progress reporting
| } | ||
| #[instrument(skip(cli, stack_list, transfer_client))] | ||
| #[instrument(skip(cli, stack_list, transfer_client), fields(indicatif.pb_show = true))] |
There was a problem hiding this comment.
Note to self, we should skip_all here, since args ends up looking so bad in the logs (since it uses the Debug impl). Nothing related to this PR though.
Description
Implementation for #153
Adds various progress indications/visualizations to
stackablectlsubcommand outputs.Some explanation regarding
println!/eprintln!changes in this PR:When indicatif is active, it needs to control how text is printed. So instead of printing straight to
stdout/stderrviaprintln!/eprintln!, we useindicatif_println!/indicatif_eprintln!so it can deal with it while rendering progress bars. If it is not active, the indicatif macros just usestdout/stderr.Definition of Done Checklist