Skip to content

feat: release upgrading support - #379

Merged
xeniape merged 19 commits into
mainfrom
feat/upgrading-support
May 28, 2025
Merged

feat: release upgrading support#379
xeniape merged 19 commits into
mainfrom
feat/upgrading-support

Conversation

@xeniape

@xeniapexeniape commented May 22, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Description

Implementation for #179

As explained here, Helm does not support upgrading CRDs, so the upgrade implementation in this PR mirrored the already described upgrade workflow from the release notes.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Documentation added or updated
- [x] Changelog updated

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@xeniapexeniape self-assigned this May 23, 2025
@xeniape
xeniape marked this pull request as ready for review May 23, 2025 07:18
@xeniapexeniape linked an issue May 23, 2025 that may be closed by this pull request
Support upgrading from one release to another #179
Closed
@xeniapexeniape moved this to Development: Waiting for Review in Stackable EngineeringMay 23, 2025
sbernauer
sbernauer reviewed May 23, 2025
View reviewed changes
Comment threadrust/stackable-cockpit/src/utils/k8s/client.rs
NickLarsenNZ

This comment was marked as resolved.

Sign in to view

@sbernauersbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable EngineeringMay 26, 2025
NickLarsenNZ

This comment was marked as resolved.

Sign in to view

@xeniape@NickLarsenNZ
Update rust/stackablectl/src/cmds/release.rs
69b75c7
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@xeniape
xeniape requested a review from NickLarsenNZMay 27, 2025 08:10
NickLarsenNZ

This comment was marked as resolved.

Sign in to view

@NickLarsenNZNickLarsenNZ mentioned this pull request May 27, 2025
Open
NickLarsenNZ
NickLarsenNZ requested changes May 27, 2025
View reviewed changes

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more things

Comment threadrust/stackablectl/src/cmds/release.rs Outdated
Comment threadrust/stackablectl/src/cmds/release.rs Outdated
@xeniape
xeniape requested a review from NickLarsenNZMay 27, 2025 18:09
NickLarsenNZ
NickLarsenNZ approved these changes May 27, 2025
View reviewed changes

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape
xeniape enabled auto-merge May 28, 2025 05:29
@xeniape
xeniape added this pull request to the merge queueMay 28, 2025
Merged via the queue into main with commit 3d373c0May 28, 2025
@xeniape
xeniape deleted the feat/upgrading-support branch May 28, 2025 05:30
@lfranckelfrancke moved this from Development: In Review to Development: Done in Stackable EngineeringMay 28, 2025
@lfranckelfrancke moved this from Development: Done to Done in Stackable EngineeringMay 28, 2025
@TechassiTechassi mentioned this pull request Jun 2, 2025
Merged
@xeniapexeniape mentioned this pull request Jun 10, 2025
Merged
@sbernauersbernauer mentioned this pull request Jul 3, 2025
Closed
76 tasks
@TechassiTechassi mentioned this pull request Aug 21, 2025
Open
19 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZNickLarsenNZNickLarsenNZ approved these changes
@sbernauersbernauerAwaiting requested review from sbernauer

Assignees

@xeniapexeniape

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support upgrading from one release to another

4 participants

@xeniape@NickLarsenNZ@sbernauer@lfrancke