Skip to content

build(stackablectl): Make binary more portable by downgrading glibc version - #407

Merged
sbernauer merged 3 commits into
mainfrom
chore/binary-glibc-version
Oct 20, 2025
Merged

build(stackablectl): Make binary more portable by downgrading glibc version#407
sbernauer merged 3 commits into
mainfrom
chore/binary-glibc-version

Conversation

@sbernauer

@sbernauersbernauer commented Oct 17, 2025

Copy link
Copy Markdown
Member

Description

Follow up of #383
Reported in Slack: https://stackable-workspace.slack.com/archives/C053Z21C9QW/p1760446364220949

Currently we don't run on Ubuntu 22.02 or Debian bookworm. This PR fixes that.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauersbernauer self-assigned this Oct 17, 2025
@sbernauersbernauer moved this to Development: Waiting for Review in Stackable EngineeringOct 17, 2025
@sbernauersbernauer mentioned this pull request Oct 17, 2025

@TechassiTechassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but I wouldn't declare this a fix. This should instead be ci.

@TechassiTechassi moved this from Development: Waiting for Review to Development: In Review in Stackable EngineeringOct 17, 2025
@sbernauer

Copy link
Copy Markdown
MemberAuthor

At first glance "build" or "chore" sounds more correct according to https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type.
Because we not only change the CI, but the actual binary that is build and ship.
But I let you make the final call

@Techassi

Copy link
Copy Markdown
Member

Yes, build also works.

@sbernauersbernauer changed the title fix(stackablectl): Make binary more portable by downgrading glibc versionbuild(stackablectl): Make binary more portable by downgrading glibc versionOct 17, 2025
@sbernauersbernauer moved this from Development: In Review to Development: Done in Stackable EngineeringOct 20, 2025
@sbernauer
sbernauer added this pull request to the merge queueOct 20, 2025
Merged via the queue into main with commit a31686dOct 20, 2025
22 checks passed
@sbernauer
sbernauer deleted the chore/binary-glibc-version branch October 20, 2025 09:30
@lfranckelfrancke moved this from Development: Done to Done in Stackable EngineeringOct 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer@Techassi@lfrancke