Uh oh!
There was an error while loading. Please reload this page.
feat: Support configuring ListenerClass preset (with sensible defaults) - #414
Conversation
Uh oh!
There was an error while loading. Please reload this page.
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Some recommended changes.
I will update the PR description.
I also think "preset" should be plural: "presets", but that's outside of the scope of this and would need to change in the chart.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Hmm, I think preset is technically more correct, as it's e.g. "stable-nodes". |
yeah I guess it can be interpreted both ways. I tend to think what it results in... It results in a number of preset ListenerClasses (which are the presets). Anyway, keep as is because it is valid too. That said, the docs say "presets": https://docs.stackable.tech/home/nightly/listener-operator/listenerclass/#presets |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Description
Part of stackabletech/issues#770
With recent changes from stackabletech/issues#770,
stackablectl demo installon kind broke, as kind by default does not have a LoadBalancer installed.We could try to document/automate/whatnot this, but I expect significant user problems with this. So instead we can make stackablectl a little bit more clever and detect kind and k3s and don't use LoadBalancers in that case.
stackablectl now tries the following order and simple passes the result to the listener-operator helm-chart:
--listener-class-presetflagPS: Yes I know the
OnceCellis not ideal, but I hope this is a temporary feature until #406 is implemented properly.Definition of Done Checklist
Author
Reviewer
Acceptance