Uh oh!
There was an error while loading. Please reload this page.
feat: Warn when stack/demo is larger than cluster - #94
Conversation
Techassi
left a comment
There was a problem hiding this comment.
Some suggestions. Nice feature!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Techassi
commented
Aug 15, 2023
Some suggested improvements: feat/check-demo-resoures...feat/check-demo-resoures-techassi |
sbernauer
commented
Aug 16, 2023
@Techassi did pull in your commit, but also push two other ones. Would be great if you could have a look! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Techassi
left a comment
There was a problem hiding this comment.
LGTM. However we need to make sure that all pre-commits are run. Either manually like pre-commit run --all-files or by installing them permanently.
nightkr
commented
Aug 17, 2023
This feels a bit misleading, since it goes by a very optimistic view of scheduling (one node with no CPU but 1TiB RAM and another node with a 128-core EPYC and no RAM still wouldn't be able to schedule anything useful together). I can see the value in giving early feedback, but I also wonder if it'd make more sense to focus on surfacing the actual scheduling errors in more discoverable ways. |
sbernauer
commented
Aug 17, 2023
@Techassi thanks for review! |
nightkr
commented
Aug 18, 2023
Yeah I don't want to block this PR on that. |
sbernauer
commented
Aug 21, 2023
Alright, but it's a good and valid point! |
Description
Related to #268
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information