Skip to content

feat: add storybook and figma pages - #192

Merged
peter-zawistowicz merged 9 commits into
mainfrom
peter-zawistowicz/storybook
Jan 11, 2024
Merged

feat: add storybook and figma pages#192
peter-zawistowicz merged 9 commits into
mainfrom
peter-zawistowicz/storybook

Conversation

@peter-zawistowicz

@peter-zawistowiczpeter-zawistowicz commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

PR Description

Summary of my changes and explanation of my decisions

  • adds page for Storybook addon
  • adds page for Figma plugin

Review PR in StackBlitzSubmitted with StackBlitz.

@bolt-new-by-stackblitz

bolt-new-by-stackblitzBot commented Jan 4, 2024

Copy link
Copy Markdown

Review PR in StackBlitz CodeflowRun & review this pull request in StackBlitz Codeflow.

@stackblitz-staging

stackblitz-stagingBot commented Jan 4, 2024

Copy link
Copy Markdown

Review PR in StackBlitz CodeflowRun & review this pull request in StackBlitz Codeflow.

@netlify

netlifyBot commented Jan 4, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for stackblitz-docs ready!

NameLink
🔨 Latest commit32cc77f
🔍 Latest deploy loghttps://app.netlify.com/sites/stackblitz-docs/deploys/65a01b475a72720008645c71
😎 Deploy Previewhttps://deploy-preview-192--stackblitz-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peter-zawistowicz

peter-zawistowicz commented Jan 8, 2024

Copy link
Copy Markdown
ContributorAuthor

@sulco updated the images and Figma install instructions. ready for another 👀

HeyGarrison
HeyGarrison approved these changes Jan 9, 2024
View reviewed changes

@HeyGarrisonHeyGarrison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

sulco
sulco reviewed Jan 11, 2024
View reviewed changes
Comment threaddocs/guides/integration/storybook-addon.md Outdated
sulco
sulco reviewed Jan 11, 2024
View reviewed changes
Comment threaddocs/guides/integration/figma-plugin.md
sulco
sulco reviewed Jan 11, 2024
View reviewed changes
Comment threaddocs/guides/integration/figma-plugin.md Outdated
sulco
sulco reviewed Jan 11, 2024
View reviewed changes

@sulcosulco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, reads great! Just left some comments about minor adjustments. After these we're good to go!

peter-zawistowicz
peter-zawistowicz commented Jan 11, 2024
View reviewed changes

@peter-zawistowiczpeter-zawistowicz left a comment •
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge w/ these final fixes!

@peter-zawistowicz
peter-zawistowicz merged commit ec21215 into mainJan 11, 2024
@peter-zawistowicz
peter-zawistowicz deleted the peter-zawistowicz/storybook branch January 11, 2024 16:51
@fvschfvsch mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sulcosulcosulco left review comments
+1 more reviewer
@HeyGarrisonHeyGarrisonHeyGarrison approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peter-zawistowicz@sulco@HeyGarrison