Skip to content

Add devenv - #208

Open
Djojavi wants to merge 4 commits into
mainfrom
dj_add_devenv
Open

Add devenv#208
Djojavi wants to merge 4 commits into
mainfrom
dj_add_devenv

Conversation

@Djojavi

Copy link
Copy Markdown
Collaborator

Added devenv
Updated documentation

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we forgot to remove some leftovers. Thanks @Djojavi

@CristhianMotocheCristhianMotoche left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Djojavi I would prefer to merge PRs that respect the Single Responsibility Principle 😅 Meaning that we just do one thing in this PR. Let's open another one for removing some of those files that aren't needed anymore for the release

Comment threadREADME.md
Comment on lines +38 to +40
```shell
direnv allow
```

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Djojavi devenv comes with a new feature for auto-loading, so we don't really need to use direnv anymore!

Comment threaddevenv.nix
{ pkgs, ... }:

{
# https://devenv.sh/reference/options/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# https://devenv.sh/reference/options/

Comment threaddevenv.nix
Comment on lines +5 to +13
packages = with pkgs; [
cabal-install
ghc
haskell-language-server
hlint
ormolu
stack
zlib
];

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Djojavi What about using the language essentials that devenv provides for Haskell?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Djojavi@CristhianMotoche