Skip to content

Yoga AUFN test environment - #234

Merged
sd109 merged 33 commits into
stackhpc/yogafrom
yoga-aufn
Jan 19, 2023
Merged

Yoga AUFN test environment#234
sd109 merged 33 commits into
stackhpc/yogafrom
yoga-aufn

Conversation

@sd109

@sd109sd109 commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

No description provided.

markgoddard
markgoddard suggested changes Nov 17, 2022
View reviewed changes
Comment threadetc/kayobe/ansible/ceph-config.yml Outdated
Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/stackhpc.yml Outdated
Comment threadetc/kayobe/environments/aufn-ceph/stackhpc.yml Outdated
Comment threadetc/kayobe/inventory/groups Outdated
Comment threadetc/kayobe/environments/aufn-ceph/stackhpc.yml Outdated
Comment threadetc/kayobe/environments/aufn-ceph/kolla.yml Outdated
@sd109

sd109 commented Nov 17, 2022

Copy link
Copy Markdown
ContributorAuthor

Are there any more changes that need made before I try testing this?

markgoddard
markgoddard suggested changes Nov 17, 2022
View reviewed changes

@markgoddardmarkgoddard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better

Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/kolla/inventory/overcloud-services.j2
Comment threadetc/kayobe/environments/aufn-ceph/kolla/inventory/overcloud-services.j2
Comment threadetc/kayobe/environments/aufn-ceph/storage.yml Outdated
markgoddard
markgoddard reviewed Nov 17, 2022
View reviewed changes

@markgoddardmarkgoddard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, give it a whirl.

markgoddard
markgoddard suggested changes Dec 6, 2022
View reviewed changes

@markgoddardmarkgoddard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract the non-AUFN bits please

Comment threadetc/kayobe/ansible/cephadm-commands.yml
Comment threadetc/kayobe/ansible/cephadm.yml Outdated
Comment threadetc/kayobe/cephadm.yml
Comment threadetc/kayobe/dnf.yml
Comment threadetc/kayobe/inventory/group_vars/overcloud/stackhpc-dnf-repos
Comment threadetc/kayobe/kolla/globals.yml Outdated
markgoddard
markgoddard suggested changes Dec 14, 2022
View reviewed changes

@markgoddardmarkgoddard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review. If you rebase your changes onto stackhpc/xena, it should pick up the bits you extracted.

Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/configure-local-networking.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/configure-openstack.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/init-runonce.sh Outdated
Comment threadetc/kayobe/environments/aufn-ceph/neutron.yml Outdated
Comment threadetc/kayobe/environments/aufn-ceph/neutron.yml Outdated
Comment threadetc/kayobe/environments/aufn-ceph/stackhpc.yml Outdated
Comment threadetc/kayobe/environments/aufn-ceph/storage.yml
Comment threadetc/kayobe/seed-hypervisor.yml Outdated
markgoddard
markgoddard reviewed Dec 19, 2022
View reviewed changes
Comment threadetc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh Outdated
sd109
sd109 commented Jan 10, 2023
View reviewed changes
Comment threadetc/kayobe/environments/aufn-ceph/configure-openstack.sh Outdated
@sd109

sd109 commented Jan 11, 2023

Copy link
Copy Markdown
ContributorAuthor

I think this is now ready to go.

@sd109
sd109 marked this pull request as ready for review January 11, 2023 14:12
@sd109
sd109 requested a review from a team as a code ownerJanuary 11, 2023 14:12
markgoddard
markgoddard previously approved these changes Jan 12, 2023
View reviewed changes

@markgoddardmarkgoddard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Scott. I rebased the change to remove the commits that were pulled out into separate PRs. I pushed your original branch to yoga-aufn-og in case you wanted to compare.

@markgoddard

markgoddard commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Looks like there are some pep8 issues: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/3904414510/jobs/6670166003

@markgoddard

markgoddard commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Could you add some basic docs in doc/source/contributor/environments/aufn-ceph.rst? It can be in a separate PR

@markgoddard

markgoddard commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Seems we have some pep8 failures

@sd109

sd109 commented Jan 18, 2023

Copy link
Copy Markdown
ContributorAuthor

How do I fix the final pep8 issue? It's complaining about {% if ... %} syntax in a yaml file.

Will add some docs separately here: https://github.com/stackhpc/stackhpc-kayobe-config/tree/yoga-aufn-docs

markgoddard
markgoddard reviewed Jan 19, 2023
View reviewed changes
Comment threadetc/kayobe/environments/aufn-ceph/kolla/config/bifrost/bifrost.yml
@sd109@markgoddard
Update etc/kayobe/environments/aufn-ceph/kolla/config/bifrost/bifrost…
92eb7bb
….yml
Co-authored-by: Mark Goddard <mark@stackhpc.com>
markgoddard
markgoddard approved these changes Jan 19, 2023
View reviewed changes

@markgoddardmarkgoddard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@markgoddard

markgoddard commented Jan 19, 2023

Copy link
Copy Markdown
Contributor

How do you feel about squashing the commits? Are they useful to keep separate?

@markgoddard

markgoddard commented Jan 19, 2023

Copy link
Copy Markdown
Contributor

How do you feel about squashing the commits? Are they useful to keep separate?

(Merge pull request is a drop down)

@sd109
sd109 merged commit 0376526 into stackhpc/yogaJan 19, 2023
@sd109
sd109 deleted the yoga-aufn branch January 19, 2023 17:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@markgoddardmarkgoddardmarkgoddard approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sd109@markgoddard