Skip to content

feat(iaas): onboard routes command - #1340

Merged
marceljk merged 4 commits into
stackitcloud:mainfrom
h3adex:feat/iaas-add-routes-command
Mar 25, 2026
Merged

feat(iaas): onboard routes command#1340
marceljk merged 4 commits into
stackitcloud:mainfrom
h3adex:feat/iaas-add-routes-command

Conversation

@h3adex

@h3adexh3adex commented Mar 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds support for routing-table routes. Waits for #1339

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex
h3adex requested a review from a team as a code ownerMarch 11, 2026 09:21
@h3adexh3adex changed the title Feat/iaas add routes commandfeat(iaas): onboard routes commandMar 11, 2026
@h3adex
h3adexforce-pushed the feat/iaas-add-routes-command branch from 761c6d9 to e82d1ccCompareMarch 11, 2026 09:22
@rubenhoenle

rubenhoenle commented Mar 11, 2026

Copy link
Copy Markdown
Member

blocked by #1339

@h3adex
h3adexforce-pushed the feat/iaas-add-routes-command branch 4 times, most recently from 148b51b to c16fd34CompareMarch 16, 2026 14:28
@h3adex

h3adex commented Mar 16, 2026

Copy link
Copy Markdown
ContributorAuthor

ready for review

@h3adex
h3adexforce-pushed the feat/iaas-add-routes-command branch 2 times, most recently from 9a6e375 to 1726436CompareMarch 17, 2026 14:30
marceljk
marceljk reviewed Mar 19, 2026
View reviewed changes
Comment threadinternal/cmd/network-area/routingtable/route/create/create.go Outdated
Comment threadinternal/cmd/network-area/routingtable/route/delete/delete.go
Comment threadinternal/cmd/network-area/routingtable/route/update/update.go Outdated
marceljk
marceljk reviewed Mar 19, 2026
View reviewed changes
Comment threadinternal/cmd/network-area/routingtable/route/create/create.go Outdated
@h3adex
h3adexforce-pushed the feat/iaas-add-routes-command branch from 1726436 to 527b5feCompareMarch 20, 2026 09:08
@h3adex
h3adex requested a review from marceljkMarch 20, 2026 09:08
@h3adex
h3adexforce-pushed the feat/iaas-add-routes-command branch from 527b5fe to 54cf26aCompareMarch 20, 2026 09:09
marceljk
marceljk reviewed Mar 23, 2026
View reviewed changes

@marceljkmarceljk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just did a final tests and found some nitpicks but beside that it's approved from my side

Comment threadinternal/cmd/network-area/routingtable/route/create/create.go Outdated
Comment threadinternal/cmd/network-area/routingtable/route/create/create.go Outdated
Comment threadinternal/cmd/network-area/routingtable/route/update/update.go Outdated
Comment threadinternal/cmd/network-area/routingtable/route/list/list.go Outdated
Comment threadinternal/cmd/network-area/routingtable/route/delete/delete.go Outdated
cgoetz-inovex
cgoetz-inovex previously approved these changes Mar 23, 2026
View reviewed changes
@marceljk
marceljkforce-pushed the feat/iaas-add-routes-command branch from ab8c5ca to fd1939fCompareMarch 25, 2026 16:15
@marceljk
marceljk enabled auto-merge (squash) March 25, 2026 16:16
@marceljk
marceljk merged commit 13d8a3b into stackitcloud:mainMar 25, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marceljkmarceljkmarceljk approved these changes
@cgoetz-inovexcgoetz-inovexcgoetz-inovex left review comments

Assignees

No one assigned

Labels

has internal tracking issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@h3adex@rubenhoenle@marceljk@cgoetz-inovex