Skip to content

chore(kms): migrate kms to new multi version sdk - #1437

Merged
cgoetz-inovex merged 3 commits into
mainfrom
chore/STACKITCLI-364-kms-sdk-migration
Jun 16, 2026
Merged

chore(kms): migrate kms to new multi version sdk#1437
cgoetz-inovex merged 3 commits into
mainfrom
chore/STACKITCLI-364-kms-sdk-migration

Conversation

@cgoetz-inovex

Copy link
Copy Markdown
Contributor

STACKITCLI-364

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex
cgoetz-inovex requested a review from a team as a code ownerJune 12, 2026 13:59
GokceGK
GokceGK previously approved these changes Jun 16, 2026
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted PackagesCoverage Δ🤖
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create50.00% (-7.63%)👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/delete46.51% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/describe76.79% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/importKey52.94% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/list43.90% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/restore46.51% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/rotate50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/create43.14% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/delete34.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/describe65.79% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/list39.47% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/destroy60.53% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/disable53.19% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/enable53.19% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/list43.90% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/restore60.53% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create48.98% (-7.92%)👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/delete41.67% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/describe76.79% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/list42.86% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/utils83.33% (ø)

Coverage by file

Changed files (no unit tests)

Changed FileCoverage ΔTotalCoveredMissed🤖
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create/create.go50.00% (-7.63%)50 (-9)25 (-9)25👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/delete/delete.go46.51% (ø)432023
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/describe/describe.go76.79% (ø)564313
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/importKey/importKey.go52.94% (ø)512724
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/list/list.go43.90% (ø)411823
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/restore/restore.go46.51% (ø)432023
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/rotate/rotate.go50.00% (ø)402020
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/create/create.go43.14% (ø)512229
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/delete/delete.go34.38% (ø)321121
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/describe/describe.go65.79% (ø)382513
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/list/list.go39.47% (ø)381523
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/destroy/destroy.go60.53% (ø)382315
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/disable/disable.go53.19% (ø)472522
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/enable/enable.go53.19% (ø)472522
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/list/list.go43.90% (ø)411823
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/restore/restore.go60.53% (ø)382315
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create/create.go48.98% (-7.92%)49 (-9)24 (-9)25👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/delete/delete.go41.67% (ø)361521
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/describe/describe.go76.79% (ø)564313
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/list/list.go42.86% (ø)421824
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/client/client.go0.00% (ø)101
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/utils/utils.go83.33% (ø)24204

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/importKey/importKey_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/restore/restore_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/rotate/rotate_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/destroy/destroy_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/disable/disable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/enable/enable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/restore/restore_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/utils/utils_test.go

@cgoetz-inovex
cgoetz-inovex merged commit 6fd51b3 into mainJun 16, 2026
3 checks passed
@cgoetz-inovex
cgoetz-inovex deleted the chore/STACKITCLI-364-kms-sdk-migration branch June 16, 2026 13:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cgoetz-inovex@GokceGK