Skip to content

Feat/region adjustment rabbitmq - #1449

Merged
marceljk merged 7 commits into
mainfrom
feat/region-adjustment-rabbitmq
Jul 6, 2026
Merged

Feat/region adjustment rabbitmq#1449
marceljk merged 7 commits into
mainfrom
feat/region-adjustment-rabbitmq

Conversation

@SerseusWasTaken

@SerseusWasTakenSerseusWasTaken commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

Migrates to rabbitmq api v2 and implements appropriate region adjustments

relates to STACKITCLI-407 and STACKITCLI-375

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTakenforce-pushed the feat/region-adjustment-rabbitmq branch 4 times, most recently from 5470441 to 10231b7CompareJune 30, 2026 06:17
@SerseusWasTaken
SerseusWasTaken marked this pull request as ready for review June 30, 2026 06:22
@SerseusWasTaken
SerseusWasTaken requested a review from a team as a code ownerJune 30, 2026 06:22
Comment threadinternal/cmd/rabbitmq/instance/create/create.go Outdated
Comment threadinternal/cmd/rabbitmq/instance/create/create.go Outdated
Comment threadinternal/cmd/rabbitmq/instance/create/create.go Outdated
Comment threadinternal/cmd/rabbitmq/instance/create/create_test.go Outdated
Comment threadinternal/cmd/rabbitmq/instance/update/update.go Outdated
Comment threadinternal/pkg/flags/flag_to_value.go Outdated
Comment threadinternal/pkg/services/rabbitmq/utils/utils.go Outdated
@SerseusWasTaken
SerseusWasTakenforce-pushed the feat/region-adjustment-rabbitmq branch from b255714 to 8d63286CompareJuly 2, 2026 12:21
@SerseusWasTaken
SerseusWasTakenforce-pushed the feat/region-adjustment-rabbitmq branch from 8d63286 to aadb2a0CompareJuly 2, 2026 12:23
marceljk
marceljk previously approved these changes Jul 6, 2026
Comment threadinternal/cmd/rabbitmq/instance/create/create.go Outdated
Comment threadinternal/cmd/rabbitmq/instance/update/update.go Outdated
Comment threadinternal/cmd/rabbitmq/instance/update/update_test.go
@marceljk
marceljk enabled auto-merge (squash) July 6, 2026 14:59
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted PackagesCoverage Δ🤖
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/create60.00% (+2.11%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/delete37.50% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/describe56.82% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/list60.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create61.86% (+0.40%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/delete26.83% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/describe65.96% (+7.62%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/list60.00% (+2.31%)👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update58.95% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/plans53.85% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/client0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils26.67% (+1.67%)👍

Coverage by file

Changed files (no unit tests)

Changed FileCoverage ΔTotalCoveredMissed🤖
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/create/create.go60.00% (+2.11%)55 (-2)3322 (-2)👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/delete/delete.go37.50% (ø)401525
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/describe/describe.go56.82% (ø)442519
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/list/list.go60.00% (ø)503020
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create/create.go61.86% (+0.40%)97 (+1)60 (+1)37👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/delete/delete.go26.83% (ø)411130
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/describe/describe.go65.96% (+7.62%)47 (-1)31 (+3)16 (-4)👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/list/list.go60.00% (+2.31%)50 (-2)3020 (-2)👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update/update.go58.95% (ø)955639
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/plans/plans.go53.85% (ø)522824
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/client/client.go0.00% (ø)101
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils/utils.go26.67% (+1.67%)30 (-2)822 (-2)👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/plans/plans_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils/utils_test.go

@marceljk
marceljk merged commit 3f95acd into mainJul 6, 2026
3 checks passed
@marceljk
marceljk deleted the feat/region-adjustment-rabbitmq branch July 6, 2026 15:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@SerseusWasTaken@marceljk@GokceGK