Skip to content

Onboard Intake (1/3): introduce intake runner command - #952

Merged
rubenhoenle merged 48 commits into
stackitcloud:mainfrom
yago-123:yg/onboard-intake
Nov 21, 2025
Merged

Onboard Intake (1/3): introduce intake runner command#952
rubenhoenle merged 48 commits into
stackitcloud:mainfrom
yago-123:yg/onboard-intake

Conversation

@yago-123

@yago-123yago-123 commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Description

This PR onboards the new STACKIT Intake (ticket) service into the CLI.

Intake is composed of three components:

  • Intake Runners: dedicated, isolated runtime data ingestion environment
  • Intakes: a specific data stream or topic within an Intake Runner
  • Intake Users: provides secure access credentials for your applications to connect to your Intake

This PR contains the Intake Runners part only to make a quicker and less overwhelming review. The remaining code (2/3) can be submitted as part of this PR once the first batch has been reviewed/approved or we can open a different PR for it (as the maintainer please).

The commands are designed to work as follows:

$ stackit-cli beta intake runner create ... $ stackit-cli beta intake create ... $ stackit-cli beta intake user create... 

Most customers will use intakes hence why we decided to go with this command structure. The folder structure will look like the following due to the hierachy desired:

$ ls stackit-cli/internal/cmd/intake
common instance # command for intakes intake.go runner user 

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@yago-123
yago-123 requested a review from a team as a code ownerSeptember 3, 2025 08:34
@yago-123

yago-123 commented Sep 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Sample CLI usage:

% ./bin/stackit intake runner create --display-name "runner-example" --max-message-size-kib 1024 --max-messages-per-hour 1000 --project-id xxx
Are you sure you want to create an Intake Runner for project "STACKIT Intake PROD"? [y/N] y
Created Intake Runner for project "STACKIT Intake PROD". Runner ID: yyy
% ./bin/stackit intake runner describe yyy --project-id xxx ATTRIBUTE │ VALUE ────────────────────────┼───────────────────────────────────────────────────────────────────────
ID │ yyy Name │ runner-example Description │ Max Message Size (KiB) │ 1024 Max Messages/Hour │ 1000 Ingestion URI │ yyy.intake.eu01.onstackit.cloud:9094 % ./bin/stackit intake runner list --project-id xxx ID │ NAME ──────────────────────────────────────┼────────────────
aaa │ testyago bbb │ runner1 zzz │ mytestrunner ddd │ runner-example fff │ runner1 yyy │ test-yago % ./bin/stackit intake runner update yyy --display-name runner-updated --project-id xxx
Update request for Intake Runner "yyy" sent successfully.
% ./bin/stackit intake runner delete yyy --project-id xxx Are you sure you want to delete Intake Runner "yyy"? [y/N] y
Deletion request for Intake Runner "yyy" sent successfully.

Comment threadinternal/cmd/intake/runner/create/create.go Outdated
Comment threadinternal/cmd/intake/runner/create/create.go Outdated
Comment threadinternal/cmd/intake/runner/delete/delete.go Outdated
Comment threadinternal/cmd/intake/runner/list/list.go Outdated
Comment threadinternal/cmd/beta/intake/runner/list/list_test.go
Comment threadinternal/cmd/intake/intake.go Outdated
Comment threadinternal/cmd/intake/common/util.go Outdated
Comment threadinternal/cmd/intake/runner/update/update.go Outdated
Comment threadinternal/pkg/config/config.go
@rubenhoenlerubenhoenle added the needs-work PR needs work from author. label Sep 4, 2025
@yago-123
yago-123force-pushed the yg/onboard-intake branch 2 times, most recently from 732eff1 to 669dbb9CompareSeptember 15, 2025 15:21
@yago-123

Copy link
Copy Markdown
ContributorAuthor

PS: notice that I messed up the branch by mistake, I had to cherry-pick until 7868e56 (last commit reviewed) and force push.

rubenhoenle
rubenhoenle previously approved these changes Sep 19, 2025
Comment threadinternal/cmd/intake/runner/update/update.go Outdated
Comment threadinternal/cmd/intake/runner/update/update.go Outdated
Comment threadinternal/cmd/intake/runner/update/update.go Outdated
Comment threadinternal/pkg/services/intake/client/client.go Outdated
Comment threadinternal/pkg/services/intake/client/client.go Outdated
Comment threadinternal/cmd/intake/runner/delete/delete.go Outdated
Comment threadinternal/cmd/intake/runner/update/update.go Outdated
@rubenhoenle

Copy link
Copy Markdown
Member

Rest looks good to me. :)

@github-actions

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@yago-123

Copy link
Copy Markdown
ContributorAuthor

keep PR open

rubenhoenle
rubenhoenle previously approved these changes Oct 6, 2025

@rubenhoenlerubenhoenle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the failing CI pipeline

Comment threadinternal/cmd/beta/intake/runner/create/create_test.go
Comment threadinternal/cmd/intake/runner/create/create_test.go Outdated
Comment threadinternal/cmd/intake/runner/create/create_test.go Outdated
Comment threadinternal/cmd/beta/intake/runner/delete/delete.go
Comment threadgo.mod Outdated
Comment threadinternal/cmd/intake/runner/list/list.go Outdated
Comment threadinternal/cmd/beta/intake/runner/describe/describe.go
Comment threadinternal/cmd/beta/intake/runner/update/update_test.go
Comment threadinternal/pkg/services/intake/client/client.go
Comment threadinternal/cmd/beta/intake/runner/delete/delete.go Outdated
Comment threadinternal/cmd/beta/intake/runner/create/create.go Outdated
Comment threadinternal/cmd/beta/intake/runner/update/update.go Outdated
rubenhoenle
rubenhoenle previously approved these changes Nov 17, 2025

@rubenhoenlerubenhoenle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Comment threadinternal/cmd/beta/intake/runner/create/create.go
Comment threadinternal/cmd/beta/intake/runner/update/update.go

@rubenhoenlerubenhoenle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Comment threadinternal/cmd/beta/intake/runner/runner.go Outdated
@rubenhoenle
rubenhoenle enabled auto-merge (squash) November 21, 2025 17:18
@rubenhoenle
rubenhoenle enabled auto-merge (squash) November 21, 2025 17:19
@rubenhoenle
rubenhoenle merged commit f7d1360 into stackitcloud:mainNov 21, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has internal tracking issueneeds-workPR needs work from author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@yago-123@rubenhoenle@Fyusel@devanshcache