Uh oh!
There was an error while loading. Please reload this page.
feat: add AssetDB (Preview) entry to the app switcher (ENG-8329) - #109
Merged
Ahmore merged 2 commits intoAug 12, 2026
Merged
Conversation
Superset is rolling out as "AssetDB v2" alongside this Redash-backed "AssetDB", so the switcher needs to offer both. The `superset` key comes from the existing /stacklet/config payload and, like the other entries, is skipped when the environment has no Superset URL. fixes: ENG-8329
Ahmore
commented
Aug 10, 2026
Author
@greptile review |
Product decision: no "v2" branding. From Redash's own switcher the Redash-backed AssetDB is always present, so the Superset entry is always the "(Preview)" variant. fixes: ENG-8329
Ahmore
commented
Aug 11, 2026
Author
@greptile review |
Ahmore
marked this pull request as ready for review
August 11, 2026 09:28
jtroup
approved these changes
Aug 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Adds an AssetDB (Preview) entry (Superset) to the
AppSwitcherdropdown, keyedon the
supersetkey already served by/stacklet/configand skipped when unset.From Redash's own switcher the Redash-backed AssetDB is always present, so the
Superset entry always carries the "(Preview)" suffix here.
How is this tested?
Two-line addition, gated by the same
isValidUrlcheck as the other entries.Related Tickets & Documents
ENG-8329