Skip to content

chore: add tests for auto-configure and remove unused test code - #76

Draft
jtroup wants to merge 1 commit into
mainfrom
james/fix-non-sso-auto-configure
Draft

chore: add tests for auto-configure and remove unused test code#76
jtroup wants to merge 1 commit into
mainfrom
james/fix-non-sso-auto-configure

Conversation

@jtroup

@jtroupjtroup commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

⚠️ tests were originally generated by AI, but I have both fixed and reviewed them

what

Add tests for auto-configure and remove unused test code

why

Tests are good

testing

Running the tests

docs

N/A

@jtroup
jtroup requested a review from a team as a code ownerAugust 8, 2025 18:40
@jtroup
jtroup marked this pull request as draft September 21, 2025 00:06

@howbazaarhowbazaar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem reasonable to me, some conflicts to deal with now.

Comment threadtests/test_cli.py
from tempfile import NamedTemporaryFile
from unittest.mock import Mock, patch

import pytest

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should fail ruff linting, do we have that in this repo?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jtroup@howbazaar